lp:~enr0n/ubuntu-release-upgrader

Author: Nick Rosbrook
Author Date: 2024-05-08 23:29:12 UTC

DistUpgradeQuirks: prevent upgrades of TPM FDE desktops

If a system has pc-kernel snap and ubuntu-desktop-minimal metpackage
installed, then it looks like a TPM FDE desktop. Use this as a condition
to prevent upgrades.

LP: #2065229

Author: Nick Rosbrook
Author Date: 2024-04-22 17:15:21 UTC

DistUpgradeQuirks: keep {netfilter,iptables}-persistent instead of ufw

This replaces commit 7907bea8f6
("DistUpgrade.cfg.jammy: keep {netfilter,iptables}-persistent installed").

Using KeepInstalledPkgs meant that ufw was kept around too, which is not
what we wanted. Just add a new quirk for this: on upgrades from jammy,
if netfilter-persistent and/or iptables-persistent are installed
alongside ufw, keep the former package(s) and remove ufw.

LP: #2061891

Author: Nick Rosbrook
Author Date: 2024-04-12 22:19:11 UTC

DistUpgradeQuirks: handle t64 replacement packages

Hint the solver to remove pre-t64 packages, and to install the
replacements instead. When we find a package whoes candidate is not
downloadable, start to search for a replacement. If we find a package
that Conficts: or Breaks:, Replaces:, and Provides: the package, use it
as a replacement.

LP: #2061175

Author: Nick Rosbrook
Author Date: 2024-04-11 19:07:41 UTC

DistUpgradeQuirks: prevent upgrades on armhf running raspi kernels

Starting in 24.04, the Raspberry Pi kernel does not support armhf.
Prevent upgrades in these cases and provide a message to the user.

LP: #2060220

Author: Nick Rosbrook
Author Date: 2024-03-26 09:05:50 UTC

DistUpgrade: rewrite any deb822 sources even if sources.list still used

The current logic will still call the old updateSourcesList() if any
non-deb822 sources are found. This means that if a system is configured
with a mix of deb822 and non-deb822 sources (e.g. PPA using deb822, but
sitll using /etc/apt/sources.list), then the deb822 sources will not get
re-written because updateDeb822Sources() is not called.

Adapt the migratedToDeb822() check to return an integer indicating if
sources are either not migrated, partially migrated, or fully migrated
to deb822. When only partially migrated, rewrite deb822 sources before
calling updateSourcesList().

LP: #2058938

Author: Nick Rosbrook
Author Date: 2023-11-10 12:04:51 UTC

DistUpgrade: remove imported/invoke-rc.d.diff

If this is still a problem, then we should carry a patch in
init-system-helpers or try to get something similar into Debian,
instead of putting this patched version of the script into our path at
runtime.

Author: Nick Rosbrook
Author Date: 2023-11-04 19:30:38 UTC

Release ubuntu-release-upgrader 1:24.04.2

Author: Nick Rosbrook
Author Date: 2023-10-12 14:52:02 UTC

Release ubuntu-release-upgrader 1:23.04.7

Author: Nick Rosbrook
Author Date: 2023-08-02 15:27:59 UTC

Release ubuntu-release-upgrader 1:23.10.5

Author: Nick Rosbrook
Author Date: 2023-07-28 18:07:28 UTC

Release ubuntu-release-upgrader 1:23.10.4

Author: Nick Rosbrook
Author Date: 2023-06-22 18:00:57 UTC

Update changelog

Author: Nick Rosbrook
Author Date: 2023-06-14 20:31:45 UTC

[WIP] DistUpgradeController: migrate to deb822 sources on upgrade

This adds general support for deb822 to ubuntu-release-upgrader.

Add a check to see if the system is still using any .list source files,
and if so, perform migration to deb822 sources. The migration itself is
pretty straight-forward - just re-write the sources as deb822, and
consolidate where appropriate.

Along with this, re-write the updateSourcesList() and
rewriteSourcesList() functions to be deb822 aware. Rather than trying to
adapt the rewriteSourcesList() function as-is, just start from scratch
and do not carry over old and probably no-longer-needed quirks.

TODO: We might actually need to do this in two phases because of how the
tarball download works. Namely, we will need the python-apt from mantic
most likely for all this to work correctly. So, for now, it might make
more sense to just run the migration code at the very end of the
upgrade to Mantic/NN (if not already migrated to deb822). Then, if we
are already migrated at the start of an upgrade, use
rewriteSourcesList2(), and eventually remove the old rewriteSourcesList().

Author: Nick Rosbrook
Author Date: 2023-05-02 12:01:03 UTC

Release ubuntu-release-upgrader 1:23.10.1

Author: Nick Rosbrook
Author Date: 2023-04-12 18:36:23 UTC

Release ubuntu-release-upgrader 1:23.04.4

Author: Nick Rosbrook
Author Date: 2023-04-03 16:39:18 UTC

Release ubuntu-release-upgrader 1:23.04.3

Author: Nick Rosbrook
Author Date: 2023-02-22 21:56:32 UTC

Release ubuntu-release-upgrader 1:23.04.2

Author: Nick Rosbrook
Author Date: 2022-10-14 14:29:53 UTC

Release ubuntu-release-upgrader 1:22.04.15

Author: Nick Rosbrook
Author Date: 2022-09-29 19:14:38 UTC

Release ubuntu-release-upgrader 1:22.10.8

Author: Nick Rosbrook
Author Date: 2022-05-26 14:57:50 UTC

releasing package ubuntu-release-upgrader version 1:22.04.11

Author: Nick Rosbrook
Author Date: 2022-05-17 15:06:16 UTC

DistUpgrade: do not show lock screen error if XDG_SESSION_TYPE is tty

The lock screen inhibit code is expected to fail on e.g. server because
the DBus service will not exist. The existing check for empty
XDG_SESSION_TYPE is not sufficient, because this variable is set to
'tty' on server.

Fix the condition so that the error message is not shown if
XDG_SESSION_TYPE is empty, or is set to 'tty'.

LP: #1973785

Author: Nick Rosbrook
Author Date: 2022-05-09 16:17:43 UTC

releasing package ubuntu-release-upgrader version 1:22.10.2

Author: Nick Rosbrook
Author Date: 2022-05-06 18:25:38 UTC

DistUpgrade: gracefully handle missing dbus module

Commit ef1158e4 ("DistUpgrade: use org.freedesktop.ScreenSaver to inhibit screen lock")
added a dependency on python3-dbus, but this added dependency was not
SRU'd to any stable releases. In most cases this is not an issue because
python3-dbus is seeded, but there is no guarantee that the package will
be present on the system.

Move the `import dbus` statement to the try block in _inhibitIdle(), and
handle any ImportErrors the same way as dbus exceptions, i.e. log the
exception and inform the user that they should manually disable their
screensaver. Note that we catch Exception rather than ImportError and
dbus.exceptions.DBusException explicitly because the latter will not be
defined if an ImportError occurs.

LP: #1965568

Author: Nick Rosbrook
Author Date: 2022-04-28 18:28:19 UTC

releasing package ubuntu-release-upgrader version 1:22.10.1

Author: Nick Rosbrook
Author Date: 2022-04-18 14:09:54 UTC

data: manually update mirrors.cfg

The age check in pre-build.sh prevented this from happening in the
previous run.

Author: Nick Rosbrook
Author Date: 2022-04-14 16:56:37 UTC

releasing package ubuntu-release-upgrader version 1:21.10.9

Author: Nick Rosbrook
Author Date: 2022-04-14 13:26:53 UTC

do-release-upgrade: Fix a typo in do-release-upgrade --help

s/comma-seprated/comma-separated

Author: Nick Rosbrook
Author Date: 2022-04-13 17:34:17 UTC

DistUpgrade: do not make UI dialog calls while EUID != 0

The screen lock prevention code has to temporarily set the EUID to the
non-root user UID so that it can make a DBus call on the user's session
bus. While the EUID is temporarily non-zero, a UI dialog may be
displayed to report the success of inhibiting the screen lock. For most
cases this is OK, but it causes an exception for the DistUpgradeViewKDE
frontend. This is because the view.information() call needs to read
dialog_error.ui from the tmpdir, but the non-root user does not have
permission to read this file.

To fix this, in _inhibitIdle(), move the information dialog call to
after the finally block which re-sets the EUID.

Author: Nick Rosbrook
Author Date: 2022-04-13 17:34:17 UTC

DistUpgrade: do not make UI dialog calls while EUID != 0

The screen lock prevention code has to temporarily set the EUID to the
non-root user UID so that it can make a DBus call on the user's session
bus. While the EUID is temporarily non-zero, a UI dialog may be
displayed to report the success of inhibiting the screen lock. For most
cases this is OK, but it causes an exception for the DistUpgradeViewKDE
frontend. This is because the view.information() call needs to read
dialog_error.ui from the tmpdir, but the non-root user does not have
permission to read this file.

To fix this, in _inhibitIdle(), move the information dialog call to
after the finally block which re-sets the EUID.

Author: Nick Rosbrook
Author Date: 2022-03-14 15:43:48 UTC

DistUpgrade: add firefox deb2snap entries for appropriate flavors

Kubuntu, Lubuntu, and Ubuntu MATE are shipping the firefox snap in
jammy. Add logic in DistUpgradeQuirks.py to allow providing a list of
metapackages in a deb2snap entry, instead of just a single entry. Then,
continue as normal if at least one metapackage in the list is installed.

Finally, update deb2snap.json so that snap:firefox is installed on the
correct flavors during dist-upgrade.

LP: #1964443

Author: Nick Rosbrook
Author Date: 2022-03-11 16:45:08 UTC

DistUpgrade: replace core18 with core20 in deb2snap.json

Author: Nick Rosbrook
Author Date: 2022-02-18 17:09:15 UTC

DistUpgrade: prevent upgrades to jammy on Power 8

Starting with jammy, ppc64el packages are compiled for Power 9
processors, and Power 8 processors are not able to upgrade to jammy. Add
a quirk to check /proc/cpuinfo for a POWER8 cpu, and abort the upgrade
if found.

LP: #1960255

Author: Nick Rosbrook
Author Date: 2022-02-09 16:28:13 UTC

DistUpgrade: use org.freedesktop.ScreenSaver to inhibit screen lock

Update the screen lock prevention code in DistUpgradeController to use
the DBus interface org.freedesktop.ScreenSaver. This was suggested as
the preferred alternative to existing quirks, which sometimes fail. If
the org.freedesktop.ScreenSaver service cannot be found, display a
message to the user suggesting that they manually ensure the lock screen
is disabled.

The org.freedesktop.ScreenSaver.Inhibit function is implemented such
that the effect only lasts as long as the caller's dbus connection
remains open [1]. This means that when the dist-upgrade completes, and
the user chooses not to reboot immediately, the screen may lock again.
This is a change in the previous behavior, which was originally added
because of LP: #1780342.

Remove the gnome-screensaver quirk and the KDE-specific code in favor of
this approach. But, leave the xdg-screensaver quirk as it may work in
cases such as xscreensaver, where the org.freedesktop.ScreenSaver
interface is not available.

[1] https://people.freedesktop.org/~hadess/idle-inhibition-spec/ch03.html

LP: #1959458

Author: Nick Rosbrook
Author Date: 2022-02-02 21:48:38 UTC

DistUpgrade: update download rates in estimated download message

Currently, the estimated download time message references 1Mbit DSL and
56k modems. These references are not useful for most modern download
rates. Update the message to reference 5Mbit and 40Mbit rates instead,
using the data in [1] as a guide.

While here, make the computation compliant with [2].

[1] https://www.cable.co.uk/broadband/speed/worldwide-speed-league/
[2] https://wiki.ubuntu.com/UnitsPolicy

LP: #1947581