lp:~mruffell/ubuntu-release-upgrader

Author: Matthew Ruffell
Author Date: 2023-01-10 01:59:53 UTC

Quirks: Change fips libgcrypt functions from subp.Popen to safer alternatives

Robie Basak pointed out during SRU review that subprocess.Popen()
requires the author to call wait() and check the return code manually
when it could be done in a more safe fashion with check_call().

Change _fipsLibgcryptDivert() to use subprocess.check_call().

Additionally, change the subprocess.Popen() for manual rm to
os.unlink(), again a safer way of removing the hmac file.

Change the tests to match new functions.

(LP: #1982534)