lp:~jamesodhunt/upstart/bug-1240686

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:upstart at revision 1552

Dimitri John Ledkov: Approve on 2013-11-03

Diff: 528 lines (+170/-40)

8 files modified

ChangeLog (+21/-1)
init/job_class.c (+8/-1)
init/job_process.c (+2/-2)
init/main.c (+8/-3)
init/tests/test_main.c (+8/-8)
test/test_util_common.c (+9/-5)
test/test_util_common.h (+4/-3)
util/tests/test_initctl.c (+110/-17)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1240686: Upstart overrides the user's umask

Undecided

Fix Released

Link a bug report

Related blueprints

1544. By James Hunt on 2013-10-18

* init/job_class.c:
  - job_class_new(): Set umask for job to current value for Session
    Init by default (LP: #1240686).
* init/job_process.c: Comments.
* init/main.c: main(): Save current umask.
* test/test_util_common.c:
  - start_upstart_common(): Add extra param for inheriting environment
    rather than hard-coding '--no-inherit-env'.
  - start_upstart(: Updated call to start_upstart_common().
* init/tests/test_main.c: Updated calls to start_upstart_common().
* test/test_util_common.h: START_UPSTART(): Updated call to
  start_upstart_common().
* util/tests/test_initctl.c:
  - Updated calls to start_upstart_common().
  - test_umask(): New tests:
    - "ensure Session Init inherits umask by default"
    - "ensure Session Init defaults umask with '--no-inherit-env'"

1543. By Scott James Remnant (Canonical) on 2013-10-03

Do not respawn jobs, that are being stopped and running pre-stop already.

1542. By Steve Langasek on 2013-10-04

Merge lp:~vorlon/upstart/lp.1235480

1541. By Dimitri John Ledkov on 2013-10-04

merge lp:~jamesodhunt/upstart/bug-1234898

1540. By James Hunt on 2013-10-04

* Merge of lp:~xnox/upstart/fix-1234841.

1539. By Dimitri John Ledkov on 2013-10-03

Merge lp:~jamesodhunt/upstart/bug-1089159

1538. By James Hunt on 2013-10-02

* test/test_util_common.c:
  - set_upstart_session(): Call get_initctl_binary() rather than using
    define value.
  - get_initctl(): As above.
  - get_initctl_binary(): Check that file exists for parity with
    get_upstart_binary().

1537. By James Hunt on 2013-10-01

* extra/upstart-file-bridge.c:
  - upstart_job_added(): Make quieter in manner consistent with other
    bridges (only display output in debug mode).
  - upstart_job_removed(): As above.

1536. By James Hunt on 2013-10-01

* init/job_process.c:job_process_jobs_running(): Removed unused
  variables.

1535. By Dimitri John Ledkov on 2013-10-01

Merge lp:~jamesodhunt/upstart/bypass-quiesce-logic-for-pid1