DirState.set_state_from_inventory() fails when we have common prefix paths "foo" and "foo-bar"

Bug #115947 reported by John A Meinel
18
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
John A Meinel

Bug Description

Calling DirState.set_state_from_inventory() will cause odd side-effects if you have paths with common prefixes.

Specifically:

  foo/
    bar/
      baz
  foo-bar/
    baz

The code is iterating over (dirname, basename, file_id) tuples and comparing them with '<', but this fails if there are similar dirnames with a '-'.

Revision history for this message
John A Meinel (jameinel) wrote :

I'll upload the patch, but it needs a test case, etc.

Changed in bzr:
assignee: nobody → jameinel
importance: Undecided → High
status: Unconfirmed → Fix Committed
Revision history for this message
John A Meinel (jameinel) wrote :
Revision history for this message
Matthew Fuller (fullermd) wrote :

Above patch no longer applies to bzr.dev.

John A Meinel (jameinel)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.