Collect revision information for snap builds
Bug #1679157 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
| launchpad-buildd |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
It would be very useful for build.snapcraft.io to be able to determine the code revision from which a given snap build ran. There's been talk of snapcraft generating a manifest of which VCS objects it used, but I'm not sure that's scheduled any time soon and I don't want to let the perfect be the enemy of the good. Furthermore, with a small amount of work in Launchpad we can collect revision information even about builds that are still running, which would be even more helpful to BSI and can't be done using the snapcraft manifest approach.
Related branches
lp:~cjwatson/launchpad-buildd/extended-snap-status
- William Grant: Approve (code)
-
Diff: 199 lines (+78/-5)5 files modifiedbuildsnap (+33/-5)
debian/changelog (+7/-0)
lpbuildd/slave.py (+11/-0)
lpbuildd/snap.py (+17/-0)
lpbuildd/tests/test_snap.py (+10/-0)
lp:~cjwatson/launchpad/db-snap-revision-id
- William Grant: Approve (code)
-
Diff: 14 lines (+10/-0)1 file modifieddatabase/schema/patch-2209-69-8.sql (+10/-0)
lp:~cjwatson/launchpad/snap-revision-id
- William Grant: Approve (code)
-
Diff: 254 lines (+96/-18)9 files modifiedlib/lp/buildmaster/interactor.py (+7/-10)
lib/lp/buildmaster/interfaces/buildqueue.py (+4/-1)
lib/lp/buildmaster/model/buildqueue.py (+14/-1)
lib/lp/buildmaster/tests/test_manager.py (+37/-6)
lib/lp/snappy/browser/tests/test_snapbuild.py (+10/-0)
lib/lp/snappy/interfaces/snapbuild.py (+6/-0)
lib/lp/snappy/model/snapbuild.py (+6/-0)
lib/lp/snappy/templates/snapbuild-index.pt (+3/-0)
lib/lp/snappy/tests/test_snapbuild.py (+9/-0)
| Changed in launchpad-buildd: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
| Changed in launchpad: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
Revision history for this message
| Colin Watson (cjwatson) wrote | #2 |
Revision history for this message
| Colin Watson (cjwatson) wrote | #5 |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #6 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad-buildd: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Colin Watson (cjwatson) wrote | #7 |
| Changed in launchpad-buildd: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
How does getting VCS metadata relate to getting the snap revision for `snap install --edge --revision`?