"portlets", "portlets_one", and "portlets_two" slots are redundant
Bug #185306 reported by
Matthew Paul Thomas
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Unassigned | ||
Bug Description
main-template.pt currently defines "portlets", "portlets_one", and "portlets_two" slots.
"portlets_one" and "portlets_two" are left over from when Launchpad had a three-column layout. All templates that use either of them should be migrated to "portlets", and the other two slots should be removed from main-template.pt.
Related branches
lp:~sinzui/launchpad/webkit-css
- Brad Crittenden (community): Approve (code)
-
Diff: 172 lines (+23/-50)7 files modifiedlib/canonical/launchpad/icing/style-3-0.css (+19/-1)
lib/canonical/launchpad/icing/style.css (+0/-16)
lib/lp/bugs/templates/bugtarget-bugs.pt (+0/-2)
lib/lp/bugs/templates/bugtask-edit.pt (+0/-9)
lib/lp/bugs/templates/bugtask-view.pt (+0/-18)
lib/lp/bugs/templates/cveset-all.pt (+0/-4)
lib/lp/registry/templates/object-timeline-graph.pt (+4/-0)
Revision history for this message
| Steve Alexander (stevea) wrote | #1 |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #2 |
| Changed in launchpad-foundations: | |
| milestone: | none → 3.0 |
| status: | New → In Progress |
| Changed in launchpad-foundations: | |
| milestone: | 3.0 → 3.1.10 |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #3 |
| visibility: | private → public |
| tags: | added: tech-debt |
| Changed in malone: | |
| importance: | Undecided → High |
| importance: | High → Undecided |
| Changed in malone: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in launchpad-foundations: | |
| milestone: | 3.1.10 → none |
| Changed in malone: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| importance: | Undecided → High |
| Changed in malone: | |
| milestone: | none → 3.1.13 |
| Changed in launchpad-foundations: | |
| milestone: | none → 3.1.13 |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #4 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| Changed in malone: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
We'll know it's completed when the command 'grep -l "portlets_