Required deb.* properties are not being set when publishing debs

Bug #2002342 reported by dann frazier
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson

Bug Description

I copied a number of debs into a soss PPA that then published those debs to Artifactory. These debs were not appearing in the Packages file, even after forcing a re-index. Turns out that these files did not have the required deb.component, deb.distribution, and deb.architecture properties set, which causes Artifactory to not include them. One example is:

https://canonical.jfrog.io/ui/repos/tree/Properties/soss-deb-stable-local/pool/b/bmake/bmake_20181221-2_amd64.deb

Related branches

Jürgen Gmach (jugmac00)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Jürgen Gmach (jugmac00)
tags: added: soyuz-publish
Revision history for this message
Colin Watson (cjwatson) wrote :
Download full text (3.4 KiB)

This happens because the .orig file is shared between multiple Debian revisions, which then causes the publisher to incorrectly try to update properties on all the files associated with an old revision of which only the .orig is still published, which results in:

Traceback (most recent call last):
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/services/scripts/base.py", line 95, in log_unhandled_exceptions_func
    return func(self, *args, **kw)
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/services/scripts/base.py", line 373, in lock_and_run
    self.run(use_web_security=use_web_security, isolation=isolation)
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/services/scripts/base.py", line 95, in log_unhandled_exceptions_func
    return func(self, *args, **kw)
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/services/scripts/base.py", line 323, in run
    self.main()
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/archivepublisher/scripts/publishdistro.py", line 505, in main
    archive_id, reset_store=reset_store_between_archives
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/archivepublisher/scripts/publishdistro.py", line 472, in processArchive
    self.publishArchive(archive, publisher)
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/archivepublisher/scripts/publishdistro.py", line 429, in publishArchive
    publisher.C_updateArtifactoryProperties(careful_indexing)
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/archivepublisher/publishing.py", line 847, in C_updateArtifactoryProperties
    old_properties=properties,
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/archivepublisher/artifactory.py", line 563, in updateProperties
    entry.updateProperties(publications, old_properties=old_properties)
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/lib/lp/archivepublisher/artifactory.py", line 407, in updateProperties
    properties_to_remove, recursive=False
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/env/lib/python3.5/site-packages/artifactory.py", line 1827, in del_properties
    return self._accessor.del_properties(self, properties, recursive)
  File "/srv/launchpad.net/production/launchpad-rev-31c78762a8046acf7ab47372e5d588ebb3759d2e/env/lib/python3.5/site-packages/artifactory.py", line 1167, in del_properties
    raise OSError(2, "No such file or directory: '%s'" % url)
FileNotFoundError: [Errno 2] No such file or directory: '[redacted]/pool/b/bind9/bind9_9.16.1-0ubuntu2.10.debian.tar.xz'

As a result, none of the work that the publisher would have done after that happens, which causes properties to be missing from a bunch of other files.

I have work in progress to fix this by skip...

Read more...

Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.