ValidTeamVocabulary not really valid
Bug #255798 reported by
Brad Crittenden
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Brad Crittenden | ||
Bug Description
The ValidTeamVocabulary was written at a time when all teams were valid. This is no longer true. The vocabulary should not include merged teams.
Originally this bug also addressed the same issue regarding ValidPersonOrTe
Related branches
lp:~bac/launchpad/bug-429802
- Aaron Bentley (community): Approve (code)
-
Diff: 142 lines (+37/-13)5 files modifiedlib/lp/registry/doc/teammembership.txt (+10/-1)
lib/lp/registry/doc/vocabularies.txt (+16/-4)
lib/lp/registry/interfaces/person.py (+1/-1)
lib/lp/registry/model/person.py (+2/-0)
lib/lp/registry/vocabularies.py (+8/-7)
| Changed in launchpad: | |
| status: | New → Triaged |
Revision history for this message
| Brad Crittenden (bac) wrote | #1 |
| tags: | added: tech-debt |
| affects: | launchpad-foundations → launchpad-registry |
| Changed in launchpad-registry: | |
| importance: | Undecided → Low |
| Changed in launchpad-registry: | |
| assignee: | nobody → Brad Crittenden (bac) |
| status: | Triaged → In Progress |
| milestone: | none → 3.1.12 |
| summary: |
- ValidTeamVocabulary and ValidPersonOrTeamCache not really valid + ValidTeamVocabulary not really valid |
| description: | updated |
Revision history for this message
| Brad Crittenden (bac) wrote | #2 |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
When fixing this bug it would be an ideal time to refactor the methods ValidPersonOrTe