Production scripts use ftest helpers
Bug #285808 reported by
Gary Poster
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Francis J. Lacoste |
Bug Description
Launchpad scripts and script infrastructure (production code) use ftest helpers `login` and `login_person`. These should use production helpers, not ftest helpers that can change to better support testing (and in fact do in a branch of mine). See the following files.
lib/canonical/
lib/canonical/
lib/canonical/
lib/canonical/
scripts/
scripts/
Related branches
lp:~flacoste/launchpad/bug-559128
Merged
into
lp:launchpad
- Gary Poster (community): Approve
-
Diff: 452 lines (+121/-96)10 files modifiedlib/canonical/launchpad/scripts/__init__.py (+16/-18)
lib/canonical/launchpad/webapp/interaction.py (+62/-1)
lib/lp/bugs/scripts/checkwatches/updater.py (+3/-2)
lib/lp/code/xmlrpc/codehosting.py (+4/-8)
lib/lp/services/scripts/base.py (+3/-13)
lib/lp/testing/__init__.py (+2/-1)
lib/lp/testing/_login.py (+25/-38)
lib/lp/testing/_webservice.py (+2/-1)
scripts/bugzilla-import.py (+2/-7)
scripts/sourceforge-import.py (+2/-7)
Changed in launchpad-foundations: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in launchpad-foundations: | |
assignee: | nobody → Francis J. Lacoste (flacoste) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-foundations: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think this needs to be re-examined, because this sort of thing causes new and interesting ways for our scripts to fail. For example:
Traceback (most recent call last): abentley/ launchpad/ stable/ scripts/ branch- rewrite. py", line 22, in <module> launchpad. database import account abentley/ launchpad/ stable/ lib/canonical/ launchpad/ database/ __init_ _.py", line 11, in <module> model.sourcepac kagerelease import * abentley/ launchpad/ stable/ lib/lp/ soyuz/model/ sourcepackagere lease.py" , line 47, in <module> model.build import Build abentley/ launchpad/ stable/ lib/lp/ soyuz/model/ build.py" , line 68, in <module> model.publishin g import SourcePackagePu blishingHistory abentley/ launchpad/ stable/ lib/lp/ soyuz/model/ publishing. py", line 61, in <module> scripts. changeoverride import ArchiveOverride rError abentley/ launchpad/ stable/ lib/lp/ soyuz/scripts/ changeoverride. py", line 18, in <module> scripts. ftpmasterbase import ( abentley/ launchpad/ stable/ lib/lp/ soyuz/scripts/ ftpmasterbase. py", line 22, in <module> scripts. base import ( abentley/ launchpad/ stable/ lib/lp/ services/ scripts/ base.py" , line 27, in <module> abentley/ launchpad/ stable/ lib/lp/ testing/ __init_ _.py", line 58, in <module> abentley/ launchpad/ stable/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ __init_ _.py", line 17, in <module> abentley/ launchpad/ stable/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ authoring/ __init_ _.py", line 17, in <module> abentley/ launchpad/ stable/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ bin/admin_ lib.py" , line 25, in <module> abentley/ launchpad/ stable/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ dep/__init_ _.py", line 15, in <module> abentley/ launchpad/ stable/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ dep/_mozrunner/ __init_ _.py", line 45, in <module> abentley/ launchpad/ stable/ eggs/windmill- 1.3beta3_ lp_r1440- py2.5.egg/ windmill/ dep/_mozrunner/ global_ settings. py", line 42, in <module> fileName, path=os. environ[ 'PATH'] ): python2. 5/UserDict. py", line 22, in __getitem__
File "/home/
from canonical.
File "/home/
from lp.soyuz.
File "/home/
from lp.soyuz.
File "/home/
from lp.soyuz.
File "/home/
from lp.soyuz.
File "/home/
from lp.soyuz.
File "/home/
from lp.services.
File "/home/
from lp.testing import ANONYMOUS
File "/home/
from windmill.authoring import WindmillTestClient
File "/home/
import authoring, bin, browser, server, conf, tools, sys
File "/home/
from windmill.bin import admin_lib
File "/home/
from windmill.dep import functest
File "/home/
import _mozrunner as mozrunner
File "/home/
import global_settings
File "/home/
def findInPath(
File "/usr/lib/
raise KeyError(key)
KeyError: 'PATH'