Column type for BranchMergeProposalJob.json_data should support binary
Bug #322819 reported by
Aaron Bentley
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Won't Fix
|
High
|
Unassigned | ||
Bug Description
JSON is defined in terms of bytes, and our json encoder produces bytestrings.
However, the column type is TEXT, which Storm treats as unicode.
We should change the column type to one that supports bytes.
Marking high because we should patch the db before we get any data that would require re-encoding.
| Changed in launchpad-bazaar: | |
| importance: | Undecided → High |
| status: | New → Triaged |
Revision history for this message
| Tim Penhey (thumper) wrote | #1 |
Revision history for this message
| Stuart Bishop (stub) wrote | #2 |
| Changed in launchpad-bazaar: | |
| status: | Triaged → Won't Fix |
| tags: | added: tech-debt |
To post a comment you must log in.
I'm not sure that changing it to binary is the right thing. We talked about this but I don't remember the resolution.