The current style of calling event.addresponse hinders translation and response middleware from being authored
Bug #334764 reported by
Brad Whittington
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ibid |
Fix Released
|
Low
|
Stefano Rivera |
Bug Description
The current style of calling event.addresponse will not work well for adding translation of responses (or other response middleware that may require altering template strings or variables before merging).
At present modules call addresponse as follows:
event.
To allow for response middleware like translation services, addresponse should be modified to allow it to be called:
event.
Adding translation will mean we can build language packs for ibid, so we could have friendly or formal english language packs.
Related branches
lp:~bradwhittington/ibid/translation
Rejected
for merging
into
lp:~ibid-core/ibid/old-trunk-pack-0.92
- Stefano Rivera: Disapprove
- Jonathan Hitchcock: Abstain
- Michael Gorven: Needs Fixing
- Diff: None lines
lp:~stefanor/ibid/translation-334764
- Jonathan Hitchcock: Approve
- Michael Gorven: Approve
- Diff: None lines
Changed in ibid: | |
assignee: | nobody → stefanor |
milestone: | 0.2 → 0.1 |
status: | Confirmed → Fix Released |
To post a comment you must log in.
Looks good. Hardly critical, but lets get this through soon.
However, in IRC discussion, we decided we prefer dict syntax.