The current style of calling event.addresponse hinders translation and response middleware from being authored

Bug #334764 reported by Brad Whittington
2
Affects Status Importance Assigned to Milestone
Ibid
Fix Released
Low
Stefano Rivera

Bug Description

The current style of calling event.addresponse will not work well for adding translation of responses (or other response middleware that may require altering template strings or variables before merging).

At present modules call addresponse as follows:
  event.addresponse(u"%s source loaded" % source)

To allow for response middleware like translation services, addresponse should be modified to allow it to be called:
  event.addresponse(u"%s source loaded",source)

Adding translation will mean we can build language packs for ibid, so we could have friendly or formal english language packs.

Related branches

Revision history for this message
Stefano Rivera (stefanor) wrote :

Looks good. Hardly critical, but lets get this through soon.

However, in IRC discussion, we decided we prefer dict syntax.

Changed in ibid:
importance: Undecided → Low
milestone: none → 0.2
status: New → Confirmed
Revision history for this message
Brad Whittington (bradwhittington) wrote :

Translation is a difficult task, so I don't know if we can ever make a bot that is fully multi-lingual, but it will have to be a primarily english, with a little bit of other languages. My thinking around language packs right now would be to add different personalities (brash, friendly, comic genius) in the form of po files. Could be customisable on an identity basis, or a global setting.

Changed in ibid:
assignee: nobody → stefanor
milestone: 0.2 → 0.1
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.