Show something on the merge proposal page while diff is being generated
Bug #336936 reported by
Jonathan Lange
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Aaron Bentley | ||
Bug Description
The merge proposal system now generates diffs - yay! However, it gives no indication at all that it's generating this diff. Some sort of display would be good.
I reckon a particularly good display would be to have an ajax progress bar or spin wheel that loaded the diff when the diff became available.
Related branches
lp:~abentley/launchpad/jobstatus
- Guilherme Salgado (community): Approve (code)
-
Diff: 280 lines (+119/-7)10 files modifiedlib/canonical/launchpad/icing/style.css (+2/-2)
lib/lp/code/browser/branchmergeproposal.py (+4/-0)
lib/lp/code/configure.zcml (+1/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+3/-0)
lib/lp/code/model/branchmergeproposal.py (+26/-2)
lib/lp/code/model/branchmergeproposaljob.py (+5/-2)
lib/lp/code/model/tests/test_branchmergeproposals.py (+52/-0)
lib/lp/code/stories/branches/xx-branch-merge-proposals.txt (+16/-0)
lib/lp/code/templates/branch-index.pt (+1/-1)
lib/lp/code/templates/branchmergeproposal-index.pt (+9/-0)
| Changed in launchpad-bazaar: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| tags: | added: code-review ui |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Released |
| milestone: | none → 10.01 |
To post a comment you must log in.
