exports broken po files with #|

Bug #340177 reported by Gabor Kelemen
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Henning Eggers

Bug Description

I just updated and downloaded totem's po file: http://launchpadlibrarian.net/23671410/po_totem-hu.po
Then, msgfmt dies on it with syntax errors. I tracked it down to the lines beginning with #| (the result of msgfmt --previous, which is enabled by default on d-l) like:

#| msgid "Default location for the \"Open...\" dialogues"
#: ../data/totem.schemas.in.h:6
msgid "Default location for the \"Open...\" dialogs"
msgstr "Az alapértelmezett hely a „Megnyitás…” ablakokban"

changing the order of the #: and #| line solves the problem.

Changed in rosetta:
assignee: nobody → henninge
importance: Undecided → High
milestone: none → 2.2.3
status: New → Triaged
Revision history for this message
Данило Шеган (danilo) wrote :

Two things to do: ignore these comments on import, and discard them on export. Reasons are simple: we can't do anything with them, and we have different plans to support similarity matching (we are already discarding fuzzy translations).

Revision history for this message
Henning Eggers (henninge) wrote :

Still, keeping them in there is fairly easy and they are information that could be used by pofile editors. It also makes the fix simpler because only the export function has to be adapted.

Revision history for this message
Данило Шеган (danilo) wrote :

FWIW, it's not something that can be used by POFile editors since we discard the translation itself. The two are useful only when they are there together, otherwise they are not useful. We should still discard data that's useless, but fixing the export bug itself is more important. If you went this way, please file a separate bug to clean-up handling of this special-type comment.

Changed in rosetta:
status: Triaged → In Progress
Revision history for this message
Henning Eggers (henninge) wrote :

Fixed in devel 8005.

Changed in rosetta:
status: In Progress → Fix Committed
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.