Launchpad itself

"Change details" for POTemplate should allow maintainers some more freedom

Bug #340662 reported by Данило Шеган on 2009-03-10

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Fix Released	Medium	Adi Roiban	Launchpad itself 10.01

Bug Description

At the moment, "change details" link on POTemplates has very limited options.

We should move at least translation domain, path and "accept translations" from "Admin" to "Change details" form.

Tags:

Related branches

lp:~adiroiban/launchpad/bug-340662

Merged into lp:launchpad

Данило Шеган (community): Disapprove on 2010-01-16

Eleanor Berger (community): Approve on 2010-01-04

lp:~adiroiban/launchpad/bug-340662-take-2

Merged into lp:launchpad/db-devel

Brad Crittenden (community): Approve (code) on 2010-01-20

Данило Шеган (danilo) on 2009-03-10

Changed in rosetta:
importance:	Undecided → Medium
status:	New → Triaged

Revision history for this message

Adi Roiban (adiroiban) wrote on 2009-12-28:

Since domain name is somehow linked to template name, I have also added „template name” in the Edit view.

Since „accept translations” can be modified, the launchpad.Edit should be allowed for disabled templates.

Changed in rosetta:
status:	Triaged → In Progress
assignee:	nobody → Adi Roiban (adiroiban)

Adi Roiban (adiroiban) on 2010-01-04

Changed in rosetta:
status:	In Progress → Fix Committed

Revision history for this message

Ursula Junque (ursinha) wrote on 2010-01-05: A commit mentioned this bug

This bug was mentioned in stable r10103 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10103>

tags:

added: qa-needstesting

Adi Roiban (adiroiban) on 2010-01-07

tags:

added: qa-ok
removed: qa-needstesting

Revision history for this message

Adi Roiban (adiroiban) wrote on 2010-01-15:

It looks like some things are broken and discussed in bug 507498

tags:	added: qa-needstesting removed: qa-ok
tags:	added: qa-bad removed: qa-needstesting

Revision history for this message

Данило Шеган (danilo) wrote on 2010-01-16:

We should definitely not allow template name to be changed, at least not yet. Changing template name is not for everyone!

Revision history for this message

Adi Roiban (adiroiban) wrote on 2010-01-17:

I apologies for all the inconveniences created by this branch. I have created the MP, thinking that such stupid mistakes will be raised during the reviewer.

I have reevaluated the usage of IPOTemplateSet and IPOTemplateSubset and I realized my foolish error.

Since we allow Launchpad.Edit to disable templates, I assume we should also allow them to enable them back.
This is why I had to change the traversal for POTemplateSubset.

If the permission were no change, once a person disabled the template he/she will not be able to enable it back.

I have created a new branch, removing „name” from Edit page, but fixing and keeping Launchapd.Edit for IPOTemplateSubset.

Please let me know if a person should be able to enable a template, once he/she had disable it, and I will do the required changes.

Adi Roiban (adiroiban) on 2010-01-21

tags:

added: qa-needstesting
removed: qa-bad

Revision history for this message

Brad Crittenden (bac) wrote on 2010-01-21:

Take 2 committed in r 10207

Curtis Hovey (sinzui) on 2010-01-21

Changed in rosetta:
milestone:	none → 10.01

Adi Roiban (adiroiban) on 2010-01-23

tags:

added: qa-ok
removed: qa-needstesting

Curtis Hovey (sinzui) on 2010-01-28

Changed in rosetta:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.