Ubuntu
notify-osd package

Fallback alert has leftmost button as default

Bug #353843 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
Fix Released
Medium
Karl Lattimer

Bug Description

notify-osd 0.9.7-0ubuntu1, Ubuntu Jaunty

1. Invoke a notification fallback alert box. For example:
  a. Choose "Lock Screen".
  b. Choose "Leave Message".
  c. Enter a message, and choose "Save".
  d. Unlock the screen.
2. Focus the "gnome-screensaver-dialog" fallback alert box, if it is not focused already.
3. Press Enter.

What happens: The "Cancel" button is triggered.
What should happen: As described in <https://wiki.ubuntu.com/NotifyOSD#Fallback%20alert%20boxes>, "None of the buttons should be set as the default (because the system can’t detect that any of them are safe as a default)."

A similar problem, with notifications using custom actions, was apparently fixed as bug 330091.

See original description

Related branches

lp:~karl-qdh/notify-osd/dialog-no-default-button
Mirco Müller (community): Approve
Diff: 19 lines (+2/-0)
1 file modified
src/dialog.c (+2/-0)
lp:ubuntu/natty/notify-osd
Revision history for this message
Matthew Paul Thomas (mpt) wrote :
description: updated
Revision history for this message
Abhishek Mukherjee (linkinpark342) wrote :

Is this a duplicate in a sense of bug 332178 - Dialogues are not HIG-compliant?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

They could be fixed at the same time, but not necessarily, so it's probably better to keep them separate. (In theory bug 332178 is six separate bugs, but at least five of them are being fixed at once.)

Mirco Müller (macslow)
Changed in notify-osd:
assignee: nobody → Mirco Müller (macslow)
importance: Undecided → Medium
status: New → Confirmed
Karl Lattimer (karl-qdh)
Changed in notify-osd:
assignee: Mirco Müller (macslow) → Karl Lattimer (karl-qdh)
Revision history for this message
Karl Lattimer (karl-qdh) wrote :

The attached branch unsets can_default on the two buttons in dialog.c, I'm not 100% sure if it has been branched from the correct branch (lp:notify-osd) but am hopeful :)

I'll discuss with mirco and put in a merge request once the branch has been scanned.

Changed in notify-osd:
status: Confirmed → Fix Committed
Sebastien Bacher (seb128)
Changed in notify-osd:
status: Fix Committed → Fix Released
Matthew Paul Thomas (mpt)
affects: notify-osd → notify-osd (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.