loggerhead

Every call to LoggerheadConfig() creates a new temp dir

Bug #358322 reported by Matt Nordhoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
Critical
Matt Nordhoff

Bug Description

Every time LoggerheadConfig() is instantiated, it creates a new SQL_DIR. And I assume it's instantiated on every, or nearly every, page load, because it created 30,000 of them and filled my /tmp directory. :D

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

I've pushed a quick fix to the attached branch. I just changed it to only create one global SQL_DIR, which may or may not be the right solution:

* Is global state related to the SQL cache okay?

* Should LoggerheadConfig be instantiated tons of times in the first place? I know it will be at least twice (serve-branches, BranchesFromFileSystemServer), so either that should be fixed or this bug matters anyway.

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

Confirming since it happens to me on another machine with the straight trunk, and marking as Critical since I assume it would fill Launchpad's /tmp in an hour. :P You might want to downgrade it to High or something, though.

Changed in loggerhead:
importance: Undecided → Critical
status: New → Confirmed
Matt Nordhoff (mnordhoff)
summary: - Every call to LoggerhedConfig() creates a new temp dir
+ Every call to LoggerheadConfig() creates a new temp dir
Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

Merged in lp:loggerhead r331. Thanks, mwhudson.

Plus the thing about only instantiating LoggerheadConfig once was merged in r330, fwiw. (It was lp:~mnordhoff/loggerhead/one-config.)

Changed in loggerhead:
assignee: nobody → Matt Nordhoff (mnordhoff)
status: Confirmed → Fix Committed
Martin Albisetti (beuno)
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.