Rhythmbox has a tag editor musicvideophotos/c/music.xml line 58

Bug #371190 reported by Shane Fagan
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-docs (Ubuntu)
Fix Released
Low
Shane Fagan

Bug Description

Binary package hint: ubuntu-docs

This line says:
"Some music players even have their own tag editor."
I think it should be:
"Rhythmbox has its own tag editor."

Tags: patch
Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :
Changed in ubuntu-docs (Ubuntu):
assignee: nobody → shane fagan (shanepatrickfagan)
Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :
Connor Imes (ckimes)
Changed in ubuntu-docs (Ubuntu):
importance: Undecided → Low
status: New → Triaged
tags: added: patch
Revision history for this message
Artur Szymanski (arteek) wrote :

Hi,

In my opinion the second added patch doesn't make sense, becuase "Rhythmbox and banshee" means the same as "Some music players" ;-)

Personally, I would leave this string without any changes.

Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

I just think it clarifies the sentence. Talking about specific players makes it clearer in my opinion.

Revision history for this message
Artur Szymanski (arteek) wrote :

Yes you are right, but take into account that if somebody find that his/her music application has tag editor he could report a bug "Not only Rhytmbox and Banshee have tag editor, my Best_musicplayer_ever has also such option".
Maybe string looks like "Some music players like Rythmbox or Banshee have their own tag editor" would be better option?

Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

That sounds good to me. Ill put up a patch to that effect.

Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

Hmmm im wondering if "Some music players like Rythmbox or Banshee have their own tag editor" is correct grammer.
Maybe "Some music players such as Rhythmbox and Banshee have their own tag editors included"

Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

Ill upload the second one and let Dougie choose which one is right.

Revision history for this message
Dougie Richardson (dougierichardson) wrote :

Hi,

Thanks for the patches I opted for "Some music players, such as Rhythmbox and Banshee have their own tag editors included". Committed it earlier.

Changed in ubuntu-docs (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Matthew East (mdke) wrote :

Released in ubuntu-docs version 9.10.2

Changed in ubuntu-docs (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.