Product page mistakenly says it's not configured for translation

Bug #371632 reported by Jeroen T. Vermeulen
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Henning Eggers

Bug Description

The product page can say that a project is not configured for translation in Launchpad when actually it is.

This is because ProductView.uses_translations checks that official_rosetta is set *and* that there is a primary_translatable. The latter is the wrong thing to check: the primary_translatable can be a package in Ubuntu (or another distro translated in Launchpad) even if the product itself does not set one.

Easy fix: make ProductView.uses_translations look only at official_rosetta, and make the references to the primary_translatable in product-translations.pt (look for "target") conditional on there actually being one.

ProductView.uses_translations doesn't seem to be used for anything else. To avoid confusion we should also rename BaseExportView.uses_translations, which instead checks for the presence of translatable templates.

Related branches

Changed in rosetta:
importance: Undecided → Medium
status: New → Triaged
tags: added: ui
Revision history for this message
Henning Eggers (henninge) wrote :

Also, the page is currently rendered empty. This happens because the notice was taken out out of the main part of the page into the top-portlet container and there only checks official_rosetta.

So the original bug is fixed, as the page does not claim that the product is not configured for translations. But it needs a new message explaining that templates need to be uploaded. Don't we have something like that already?

Revision history for this message
Henning Eggers (henninge) wrote :

Ok, we have that for a product series. I added a simple note for the product-translations and changed the conditions a little so that the page is not left empty.

Changed in rosetta:
status: Triaged → In Progress
assignee: nobody → Henning Eggers (henninge)
milestone: none → 10.01
Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug
Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.