No attribute _find_revision_outside_set

Bug #387294 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Andrew Bennetts

Bug Description

Trying to branch from a dev7 repo into a 2a repo:

ganieda:~/fetchmail% bzr.dev branch sftp://233pc197.sshunet.nl/~/mirror/fetchmail/trunk
Control socket connect(/home/jelmer/.ssh/master-jelmer@233pc197.sshunet.nl:22): Connection refused
ControlSocket /home/jelmer/.ssh/master-jelmer@233pc197.sshunet.nl:22 already exists, disabling multiplexing
bzr: ERROR: exceptions.AttributeError: 'CHKInventoryRepository' object has no attribute '_find_revision_outside_set'

Traceback (most recent call last):
  File "/home/jelmer/bzr/bzr.dev/bzrlib/commands.py", line 729, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/commands.py", line 924, in run_bzr
    ret = run(*run_argv)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/commands.py", line 560, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/builtins.py", line 1147, in run
    source_branch=br_from)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/bzrdir.py", line 1176, in sprout
    result_repo.fetch(source_repository, revision_id=revision_id)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/repository.py", line 1552, in fetch
    find_ghosts=find_ghosts, fetch_spec=fetch_spec)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/repository.py", line 3126, in fetch
    pb=pb, find_ghosts=find_ghosts)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/fetch.py", line 82, in __init__
    self.__fetch()
  File "/home/jelmer/bzr/bzr.dev/bzrlib/fetch.py", line 108, in __fetch
    self._fetch_everything_for_search(search)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/fetch.py", line 136, in _fetch_everything_for_search
    stream, from_format, [])
  File "/home/jelmer/bzr/bzr.dev/bzrlib/repository.py", line 4029, in insert_stream
    return self._locked_insert_stream(stream, src_format, is_resume)
  File "/home/jelmer/bzr/bzr.dev/bzrlib/repository.py", line 4058, in _locked_insert_stream
    for substream_type, substream in stream:
  File "/home/jelmer/bzr/bzr.dev/bzrlib/repository.py", line 4236, in get_stream
    for info in self._get_inventory_stream(revs):
  File "/home/jelmer/bzr/bzr.dev/bzrlib/repository.py", line 4331, in _get_chk_inventory_stream
    start_rev_id = self.from_repository._find_revision_outside_set(
AttributeError: 'CHKInventoryRepository' object has no attribute '_find_revision_outside_set'

bzr 1.17dev on python 2.5.4 (linux2)
arguments: ['/home/jelmer/bzr/bzr.dev/bzr', 'branch', 'sftp://233pc197.sshunet.nl/~/mirror/fetchmail/trunk']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  avahi /home/jelmer/.bazaar/dev-plugins/avahi [unknown]
  builddeb /home/jelmer/.bazaar/dev-plugins/builddeb [unknown]
  bzrtools /home/jelmer/.bazaar/dev-plugins/bzrtools [1.16]
  cia /home/jelmer/.bazaar/dev-plugins/cia [1.0dev]
  cvsps_import /usr/lib/python2.5/site-packages/bzrlib/plugins/cvsps_import [unknown]
  dbus /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus [0.1dev]
  email /home/jelmer/.bazaar/dev-plugins/email [unknown]
  etckeeper /usr/lib/python2.5/site-packages/bzrlib/plugins/etckeeper [unknown]
  fastimport /usr/lib/python2.5/site-packages/bzrlib/plugins/fastimport [0.8dev]
  git /home/jelmer/.bazaar/dev-plugins/git [0.3.3dev]
  global_log /home/jelmer/.bazaar/dev-plugins/global_log [unknown]
  gtk /home/jelmer/.bazaar/dev-plugins/gtk [0.96.0.dev.1]
  hg /home/jelmer/.bazaar/dev-plugins/hg [unknown]
  jelmer /home/jelmer/.bazaar/dev-plugins/jelmer [unknown]
  keywords /home/jelmer/.bazaar/dev-plugins/keywords [unknown]
  launchpad /home/jelmer/bzr/bzr.dev/bzrlib/plugins/launchpad [1.17dev]
  loom /home/jelmer/.bazaar/dev-plugins/loom [1.4dev]
  mergedirstatus /home/jelmer/.bazaar/dev-plugins/mergedirstatus [0.0.1dev]
  netrc_credential_store /home/jelmer/bzr/bzr.dev/bzrlib/plugins/netrc_credential_store [1.17dev]
  plugin_info /home/jelmer/.bazaar/dev-plugins/plugin_info [1.3dev]
  pqm /home/jelmer/.bazaar/dev-plugins/pqm [1.0dev]
  qbzr /home/jelmer/.bazaar/dev-plugins/qbzr [0.12dev]
  rebase /home/jelmer/.bazaar/dev-plugins/rebase [0.5.1dev]
  search /home/jelmer/.bazaar/dev-plugins/search [1.7dev]
  stats /home/jelmer/.bazaar/dev-plugins/stats [unknown]
  svn /home/jelmer/.bazaar/dev-plugins/svn [0.6.2dev]
  upload /home/jelmer/.bazaar/dev-plugins/upload [1.0dev]
  vimdiff /home/jelmer/.bazaar/dev-plugins/vimdiff [unknown]
  webdav /home/jelmer/.bazaar/dev-plugins/webdav [1.12]
  xmloutput /home/jelmer/.bazaar/dev-plugins/xmloutput [0.8.4]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

Revision history for this message
John A Meinel (jameinel) wrote :

seems we have some missing test coverage as I removed that function quite a while back

I guess this is the first time that we have a chk => chk fetch that
1) Doesn't exactly match "network_name()" so the GroupCHKStreamSource doesn't kick in
2) Uses exactly the same serializer so the InterDifferingSerializer code doesn't kick in

So we end up using the generic fetch, which was using a function that is no longer present for CHK format repositories. I'll fix.
(Note that this only triggers between --dev7 and --2a, since otherwise IDS triggers)

Changed in bzr:
assignee: nobody → John A Meinel (jameinel)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Martin Pool (mbp) wrote :

John says: Andrew's probably now removed this code path; in any case this error only occurs when fetching from a dev7 to 2a format.

Changed in bzr:
assignee: John A Meinel (jameinel) → Andrew Bennetts (spiv)
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.