IWebServiceConfiguration.set_hop_by_hop_headers broke backward compatibility

Bug #452750 reported by Barry Warsaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lazr.restful
Won't Fix
Undecided
Unassigned

Bug Description

IWebServiceConfiguration recently grew an attribute set_hop_by_hop_headers, but this was done in a backwards incompatible way. My lazr.restful application (mailman) just grabbed the latest lazr.restful and broke because my IWebServiceConfiguration did not have this attribute.

The easy fix in this case is to use getattr() in applyTransferEncoding, defaulting the value to False if the attribute is missing.

You might argue that at 0.9.13, the API is not guaranteed to be stable.

You might argue that I really should be using BaseWSGIWebServiceConfiguration.

You might be right, and yet it would still be good to advertise the change better. There's no mention in the NEWS file about requiring this additional attribute.

Revision history for this message
Leonard Richardson (leonardr) wrote :

I've updated the NEWS file with explicit instructions.

Changed in lazr.restful:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.