series +index and +series must limit or batch milestones
Bug #490659 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Edwin Grubbs | ||
Bug Description
Oops OOPS-1430D437 was caused by by a generous glob that the PRF used to create more than 500 milestones on a series. The older milestones are not interesting in most cases. The series +index and the +series pages should limit the number of milestones it works with. The default batch size is probably correct. The +series can link to the series +index when the limit is exceeded. the series page can batch the milestones.
Related branches
lp:~edwin-grubbs/launchpad/bug-490659-series-timeout
- Stuart Bishop (community): Approve (db)
- Robert Collins (community): Approve
- Brad Crittenden (community): Approve (code)
-
Diff: 429 lines (+135/-62)17 files modifieddatabase/schema/patch-2208-01-0.sql (+9/-0)
database/schema/security.cfg (+1/-0)
database/schema/trusted.sql (+27/-0)
lib/canonical/launchpad/webapp/sorting.py (+3/-2)
lib/lp/registry/browser/__init__.py (+1/-1)
lib/lp/registry/browser/configure.zcml (+7/-0)
lib/lp/registry/browser/productseries.py (+14/-0)
lib/lp/registry/browser/tests/productseries-views.txt (+1/-1)
lib/lp/registry/browser/tests/test_milestone.py (+1/-1)
lib/lp/registry/interfaces/milestone.py (+2/-0)
lib/lp/registry/model/milestone.py (+9/-2)
lib/lp/registry/model/projectgroup.py (+17/-5)
lib/lp/registry/stories/productseries/xx-productseries-series.txt (+2/-2)
lib/lp/registry/templates/object-milestones.pt (+2/-2)
lib/lp/registry/templates/productseries-detailed-display.pt (+38/-0)
lib/lp/registry/templates/productseries-macros.pt (+0/-42)
lib/lp/registry/templates/productseries-status.pt (+1/-4)
lp:~edwin-grubbs/launchpad/bug-490659-series-timeout-part2
- Graham Binns (community): Approve (code)
-
Diff: 288 lines (+120/-13)10 files modifiedlib/lp/registry/browser/distroseries.py (+4/-0)
lib/lp/registry/browser/productseries.py (+6/-1)
lib/lp/registry/browser/tests/test_series_views.py (+42/-4)
lib/lp/registry/interfaces/product.py (+4/-1)
lib/lp/registry/interfaces/productseries.py (+4/-1)
lib/lp/registry/model/milestone.py (+5/-2)
lib/lp/registry/model/productseries.py (+4/-1)
lib/lp/registry/templates/productseries-milestone-table-row.pt (+1/-1)
lib/lp/registry/templates/productseries-table-releases.pt (+6/-2)
lib/lp/registry/tests/test_product.py (+44/-0)
| Changed in launchpad-registry: | |
| milestone: | none → 3.1.12 |
| Changed in launchpad-registry: | |
| milestone: | 3.1.12 → none |
| Changed in launchpad-registry: | |
| milestone: | none → series-3.1 |
| Changed in launchpad-registry: | |
| assignee: | nobody → Edwin Grubbs (edwin-grubbs) |
| status: | Triaged → In Progress |
| Changed in launchpad-registry: | |
| status: | In Progress → Triaged |
| assignee: | Edwin Grubbs (edwin-grubbs) → nobody |
| Changed in launchpad-registry: | |
| assignee: | nobody → Edwin Grubbs (edwin-grubbs) |
| status: | Triaged → In Progress |
| Changed in launchpad-registry: | |
| milestone: | series-future → 10.09 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-registry: | |
| status: | Fix Committed → In Progress |
| tags: | removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-stable r9696 <http://