Launchpad itself

Template page not available to rosetta-admins if translations are not open for the series

Bug #497438 reported by David Planella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Adi Roiban
Launchpad itself 10.01

Bug Description

While reviewing the import queue for Lucid, and as a member of rosetta-admins and ubuntu-translations-coordinators, I've noticed the following:

If I go to https://translations.edge.launchpad.net/ubuntu/lucid/+source/gfxboot-theme-ubuntu, I can see the list of templates for that package in my preferred languages.

However, when I try to access the template page at https://translations.edge.launchpad.net/ubuntu/lucid/+source/gfxboot-theme-ubuntu/+pots/bootloader, I get a "Translation page is not available. Translations for this release series are not available yet." error message and cannot access the page. The same happens when I try to access the +admin page.

See original description

Related branches

lp:~adiroiban/launchpad/bug-497438
Aaron Bentley (community): Approve
Diff: 357 lines (+108/-81)
8 files modified
lib/canonical/launchpad/security.py (+21/-5)
lib/canonical/launchpad/testing/pages.py (+28/-4)
lib/lp/registry/browser/distroseries.py (+2/-1)
lib/lp/registry/browser/sourcepackage.py (+2/-1)
lib/lp/translations/browser/distroseries.py (+1/-1)
lib/lp/translations/stories/distroseries/xx-distroseries-translations.txt (+22/-68)
lib/lp/translations/stories/productseries/xx-productseries-translations.txt (+31/-1)
lib/lp/translations/stories/standalone/xx-language.txt (+1/-0)
David Planella (dpm)
description: updated
Revision history for this message
Данило Шеган (danilo) wrote :

This is probably related to the rework of translation permissions we did for potemplate pages. I am sure Adi would be interested in looking into this :)

Changed in rosetta:
status: New → Triaged
importance: Undecided → High
Adi Roiban (adiroiban)
Changed in rosetta:
assignee: nobody → Adi Roiban (adiroiban)
Revision history for this message
Adi Roiban (adiroiban) wrote :

I pushed a first attempt in solving this bug.

I can solve this bug by just replacing launchpad.Admin with launchapd.TranslationsAdmin,
but I think a nicer approach would be to have all the logic required by checkTranslationsViewable in a single place.
Now it is split between registry and translations.

Adi Roiban (adiroiban)
Changed in rosetta:
status: Triaged → In Progress
Adi Roiban (adiroiban)
Changed in rosetta:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug

This bug was mentioned in stable r10078 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10078>

tags: added: qa-needstesting
Adi Roiban (adiroiban)
tags: added: qa-ok
removed: qa-needstesting
Jeroen T. Vermeulen (jtv)
Changed in rosetta:
milestone: none → 10.01
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
Revision history for this message
David Planella (dpm) wrote :

While this is fixed for lp.net, I've noticed that today the bug is present again in edge.

Let me know if you'd like me to open a separate bug for this, for now I'm simply adding the comment and not changing the bug status.

Revision history for this message
Adi Roiban (adiroiban) wrote :

Hi David, can you provide the link to the page with problems?

Cheers,
Adi

Revision history for this message
David Planella (dpm) wrote :

Unfortunately, I can not provide a direct link or try to reproduce it, as translations are now open.

I was trying to access the openoffice.org templates (which have been disabled now, so I'll just use evolution as an example), and IIRC neither accessing the template page (e.g. https://translations.edge.launchpad.net/ubuntu/lucid/+source/evolution/+pots/evolution) nor its admin page (https://translations.edge.launchpad.net/ubuntu/lucid/+source/evolution/+pots/evolution/+admin) worked.

It had been working just the day before, so something happened between that day and when I reported it. Arne had the same experience when trying to access the firefox templates that day, but fortunately disabling edge redirection worked for us.

Revision history for this message
Adi Roiban (adiroiban) wrote :

Thanks for looking into this bug. I have reproduces this bug on my local machine.

Most probably this regression was caused by bug 509252.

I will push a new fix for this bug and improve the tests.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.