bzr Upload plugin

.bzrignore-upload not work for directories

Bug #499525 reported by Paweł Jaczewski
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
bzr Upload plugin
Fix Released
High
Martin Albisetti
bzr Upload plugin 1.0.0

Bug Description

My .bzrignore-upload file:

application/modules/cart/
application/modules/cart/*

Second line was added later. When I run bzr upload:

…
Ignoring application/modules/cart
Uploading application/modules/cart/Cart.css
bzr: ERROR: No such file: …
...

Bzr upload is trying to send files to the folder which doesn't exist.

Related branches

lp:~beuno/bzr-upload/bug-499525
Rejected for merging into lp:bzr-upload
Vincent Ladeuil: Disapprove
Diff: 46 lines (+17/-2)
2 files modified
__init__.py (+4/-2)
tests/test_upload.py (+13/-0)
lp:bzr-upload
Revision history for this message
Martin Albisetti (beuno) wrote :

Thanks for reporting the bug. I will look into it tomorrow and try to push a fix. It seems it's not recursively ignoring for directories.

Changed in bzr-upload:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Martin Albisetti (beuno)
Revision history for this message
Martin Albisetti (beuno) wrote :

Hi Jaco,

The branch that fixes this is attached to the bug. Could you give it a try and confirm that it fixes your problem?
In the mean time, I'm proposing it for merging.

Changed in bzr-upload:
status: Triaged → In Progress
Revision history for this message
Paweł Jaczewski (j4co) wrote :

Great, is works correctly - great thanks.

I also noticed that masks didn't work like in .bzrignore (e.g. folder/*.tmp) - I don't know whether it bug whether such an option wasn't predicted.

(Sorry for my english).

Revision history for this message
Martin Albisetti (beuno) wrote :

regex expressions aren't supported, but I've filed bug 499941 to implement it in the future.
Thanks for the report and verification, I'll merge it into trunk when I get a review of the change.

Vincent Ladeuil (vila)
Changed in bzr-upload:
milestone: none → 1.0
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.