Permission checkers in security.py must use IPersonRoles adapter.
Bug #506454 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Henning Eggers | ||
Bug Description
This is a follow-up to bug 503454 to make use of the IPersonRoles adapter in the permission checkers in security.py. Since this adapter is about making things easier to read and maintain, the fix should make security.py exactly that.
Related branches
lp:~henninge/launchpad/bug-503454-security-py
- Edwin Grubbs (community): Approve (code)
-
Diff: 1321 lines (+302/-263)7 files modifiedlib/canonical/launchpad/doc/hasowner-authorization.txt (+5/-5)
lib/canonical/launchpad/doc/personroles.txt (+130/-0)
lib/canonical/launchpad/interfaces/launchpad.py (+8/-1)
lib/canonical/launchpad/security.py (+129/-240)
lib/canonical/launchpad/tests/test_personroles.py (+10/-4)
lib/canonical/launchpad/utilities/personroles.py (+14/-7)
lib/lp/code/doc/branch-visibility.txt (+6/-6)
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote A commit mentioned this bug | #2 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in devel r10179 <http://