PPA access granted for XXXX mail does not identify the PPA.

Bug #509370 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Nelson

Bug Description

 affects soyuz
 done

The mail (sample below) when a private PPA access is given doesn't
identify the PPA - the 'name' of a PPA is not unique at all.

If one has more than one private PPA this really can be less than the
needed clarity.

---------
Hello Robert Collins,

Launchpad: access to a private archive
--------------------------------------

Neil J. Patel has granted you access to a private software archive
"Release PPA", which is hosted by Launchpad.

To start downloading and using software from this archive you need to
view your access details by visiting this link:

<https://edge.launchpad.net/~lifeless/+archivesubscriptions>

You can find out more about Neil J. Patel here:

<https://edge.launchpad.net/~njpatel>

If you'd prefer not to use software from this archive, you can safely
ignore this email. However, if you have any concerns you can contact the
Launchpad team by emailing <email address hidden>

Regards,
The Launchpad team

Hello Robert Collins,

Launchpad: access to a private archive
--------------------------------------

Neil J. Patel has granted you access to a private software archive
"Release PPA", which is hosted by Launchpad.

To start downloading and using software from this archive you need to
view your access details by visiting this link:

<https://edge.launchpad.net/~lifeless/+archivesubscriptions>

You can find out more about Neil J. Patel here:

<https://edge.launchpad.net/~njpatel>

If you'd prefer not to use software from this archive, you can safely
ignore this email. However, if you have any concerns you can contact the
Launchpad team by emailing <email address hidden>

Regards,
The Launchpad team

Related branches

Changed in soyuz:
status: New → Triaged
importance: Undecided → Low
tags: added: email ppa
tags: added: trivial
Revision history for this message
Julian Edwards (julian-edwards) wrote :

 - the +archivesubscriptions page makes the same mistake, that page
could list the team name, archive name and the first part of the
description, like this:

  *anjali-team: Daily PPA* Builds of the latest development snapshot of
deskt... [ x ]
  *galeon: New feature builds* Packages which test features which are
about t... [ x ]

Changed in soyuz:
importance: Low → High
milestone: none → 10.02
assignee: nobody → Michael Nelson (michael.nelson)
Changed in soyuz:
status: Triaged → In Progress
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Robert,

I've updated the email to include the actual (unique-to-that-user) ppa name (as opposed to the displayname), as well as the PPA description (which is obviously not necessarily unique, but should help provide context to the subscription).

I've also updated the corresponding LP page with the same info - minus the description (as it's not viewable to the subscriber, although we can address that with bug 336779).

You can see the updates on the MP linked above (and a screenshot). Let me know if you think it can be improved at all.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

08:49 < lifeless> noodles775: the key thing I'd want to see is the ppa: url
08:49 < lifeless> noodles775: which is perhaps what you mean by 'actual PPA name'
08:49 < lifeless> noodles775: the problem being that many many people have a PPA called 'releases' :)
08:50 < noodles775> lifeless: by 'actual PPA name' I mean the IArchive.name property which is what is used in the URL. Including the complete URL has a few issues, the main being that the user *doesn't* have access to view the URL.
08:51 < noodles775> (and won't even when they are subscribed - they can download software, but not see the details of uploads etc.
08:52 < lifeless> noodles775: I don't understand the issue: the URL is what they add to add-apt-repository etc - its the unique key for the thing.
08:52 < lifeless> noodles775: I don't know what IArchive.name property /means/
08:52 < noodles775> lifeless: ah, the apt url - right, I thought you meant the LP url.
08:52 < lifeless> noodles775: but here is my test: If I can be confused because someone else has a similarly named PPA, then the bug won't be fixed.
08:53 < wgrant> The URL, or ppa:wgrant/ppa?
8:56 < noodles775> wgrant: right - As long as owner / ppa name is there it's sufficient to uniquely identify it. Currently the email includes the name, but not the owner (instead displaying info about the person who subscribed you, which won't always be the same)
08:57 < lifeless> wgrant: so, ppa:wgrant/ppa, and https://launchpad.net/~wgrant/+archive/ppa - either would be fine for me
08:57 < noodles775> Neither of those are actually accessible, but yes, the unique info is contained there.
08:57 < lifeless> and I don't want to pin noodles775 down to doing something that doesn't make sense, which is why I'm trying to keep it high level - that both the owner and url element, not the visible description, need to be visible.
08:58 < lifeless> noodles775: great, I shall be happy then
08:58 < noodles775> Yep, that's great. Thanks.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Updated to the email so that the relevant bit now states:

   Celso Providelo has granted you access to a private software archive
    "PPA for Celso Providelo" (ppa:cprov/ppa), which is hosted by Launchpad
    and has the following description:
    <BLANKLINE>
    packages to help my friends.
    <BLANKLINE>
    To start downloading and using software from this archive you need to...

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit
Changed in soyuz:
status: In Progress → Fix Committed
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.