Code YUI module naming conventions

Bug #513270 reported by Edwin Grubbs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Paul Hummer

Bug Description

Please fix the following inconsistencies between module directories,
module names, and namespaces as described in the JavascriptReviewNotes.

https://dev.launchpad.net/JavaScriptReviewNotes#Naming%20Javascript%20Modules%20and%20Namespaces

Also, please run ./bin/jslint on the modified javascript files.

c/l/javascript/code/branchstatus.js:
    YUI.add('code.branchstatus', function(Y) {
        Y.branchstatus = Y.namespace('code.branchstatus');
        Y.branchstatus.connect_status = function(conf) {

    For example, the above code should be changed to:
        YUI.add('code.branchstatus', function(Y) {
            var module = Y.namespace('code.branchstatus');
            module.connect_status = function(conf) {

c/l/javascript/code/popupdiff.js:
    YUI.add('code.branchmergeproposal.popupdiff', function(Y) {
        var popupdiff = Y.namespace('code.branchmergeproposal.popupdiff');

c/l/javascript/code/branchsubscription.js:
    YUI.add('code.branchsubscription', function(Y) {
        Y.branchsubscription = Y.namespace('code.branchsubscription');

c/l/javascript/code/branchmergeproposal.js:
    YUI.add('code.branchmergeproposal', function(Y) {
        Y.code.branchmergeproposal = Y.namespace('code.branchmergeproposal');
        Y.code.branchmergeproposal.connect_status = function(conf) {

c/l/javascript/code/branchlinks.js:
    YUI.add('code.branchlinks', function(Y) {
        Y.branchlinks = Y.namespace('code.branchlinks');
        Y.branchlinks.connect_branchlinks = function() {

c/l/javascript/code/codereview.js:
    YUI.add('code.codereview', function(Y) {
        Y.codereview = Y.namespace('code.codereview');
        Y.codereview.connect_links = function() {
        Y.codereview.NumberToggle = NumberToggle;

Tags: lp-code qa-ok

Related branches

Paul Hummer (rockstar)
Changed in launchpad-code:
assignee: nobody → Paul Hummer (rockstar)
status: Triaged → In Progress
milestone: none → 10.02
Paul Hummer (rockstar)
Changed in launchpad-code:
milestone: 10.02 → 10.03
Revision history for this message
Paul Hummer (rockstar) wrote :

Fixed in devel 10492

Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Revision history for this message
Ursula Junque (ursinha) wrote :
Revision history for this message
Tim Penhey (thumper) wrote :

It either passes the windmill tests or it doesn't.

tags: added: qa-ok
removed: qa-needstesting
Paul Hummer (rockstar)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.