Code YUI module naming conventions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Paul Hummer |
Bug Description
Please fix the following inconsistencies between module directories,
module names, and namespaces as described in the JavascriptRevie
https:/
Also, please run ./bin/jslint on the modified javascript files.
c/l/javascript/
YUI.
For example, the above code should be changed to:
var module = Y.namespace(
c/l/javascript/
YUI.
var popupdiff = Y.namespace(
c/l/javascript/
YUI.
c/l/javascript/
YUI.
c/l/javascript/
YUI.
c/l/javascript/
YUI.
Related branches
- Graham Binns (community): Approve (code)
-
Diff: 343 lines (+49/-47)11 files modifiedlib/canonical/launchpad/javascript/code/branchlinks.js (+4/-4)
lib/canonical/launchpad/javascript/code/branchmergeproposal.js (+5/-5)
lib/canonical/launchpad/javascript/code/branchstatus.js (+4/-4)
lib/canonical/launchpad/javascript/code/codereview.js (+9/-7)
lib/canonical/launchpad/javascript/code/popupdiff.js (+6/-6)
lib/canonical/launchpad/javascript/code/subscription.js (+4/-4)
lib/canonical/launchpad/windmill/jstests/launchpad_ajax.js (+2/-2)
lib/lp/bugs/templates/bugtask-index.pt (+2/-2)
lib/lp/code/templates/branch-index.pt (+6/-6)
lib/lp/code/templates/branch-related-bugs-specs.pt (+2/-2)
lib/lp/code/templates/branchmergeproposal-index.pt (+5/-5)
Changed in launchpad-code: | |
assignee: | nobody → Paul Hummer (rockstar) |
status: | Triaged → In Progress |
milestone: | none → 10.02 |
Changed in launchpad-code: | |
milestone: | 10.02 → 10.03 |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
Fixed in devel 10492