Soyuz YUI module naming conventions

Bug #513272 reported by Edwin Grubbs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Nelson

Bug Description

Please fix the following inconsistencies between module directories,
module names, and namespaces as described in the JavascriptReviewNotes.

https://dev.launchpad.net/JavaScriptReviewNotes#Naming%20Javascript%20Modules%20and%20Namespaces

Also, please run ./bin/jslint on the modified javascript files.

c/l/javascript/soyuz/lp_dynamic_dom_updater.js:
    YUI.add('soyuz.dynamic_dom_updater', function(Y) {
        var lp = Y.namespace('lp');
        Y.lp.DomUpdater = DomUpdater;
        Y.lp.DynamicDomUpdater = DynamicDomUpdater;

    For example, the above code should be changed to:
        YUI.add('soyuz.dynamic_dom_updater', function(Y) {
            var module = Y.namespace('soyuz.dynamic_dom_updater');
            module.DomUpdater = function() {...
            module.DynamicDomUpdater = function() {...

c/l/javascript/soyuz/archivesubscribers_index.js:
    YUI.add('soyuz.archivesubscribers_index', function(Y) {
        var soyuz = Y.namespace('soyuz');
        Y.soyuz.setup_archivesubscribers_index = function() {

c/l/javascript/soyuz/base.js:
    YUI.add('soyuz-base', function(Y) {
        var soyuz = Y.namespace('soyuz');

Tags: lp-soyuz qa-ok
Changed in soyuz:
status: Triaged → In Progress
assignee: nobody → Michael Nelson (michael.nelson)
Changed in soyuz:
status: In Progress → Fix Committed
milestone: none → 10.09
tags: added: qa-ok
Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.