Split pottery code for intltool detection
Bug #517080 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Henning Eggers | ||
Bug Description
The code that checks a branch for a possible intltool structure should be simple and not include a call to intltool. This code will be run on the script host to decide if an intltool build will be started for a branch. This detection should be split out of the current code.
Related branches
lp:~henninge/launchpad/bug-517080-pottery-split
- Jeroen T. Vermeulen (community): Approve (code)
-
Diff: 319 lines (+104/-47)3 files modifiedlib/lp/testing/__init__.py (+8/-8)
lib/lp/translations/pottery/detect_intltool.py (+35/-0)
lib/lp/translations/tests/test_pottery_detect_intltool.py (+61/-39)
Revision history for this message
| Henning Eggers (henninge) wrote | #1 |
| Changed in rosetta: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Henning Eggers (henninge) |
| milestone: | none → 10.02 |
Revision history for this message
| Ursula Junque (ursinha) wrote A commit mentioned this bug | #2 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-untestable removed: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 517080 Fix released | #3 |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Actually, the check will run as part of a BranchJob, so it will receive a bzr Tree object to search through. The check should just return "True" if the tree is likely to contain an intltool structure and "False" if it definitely doesn't.
At the moment, checking for the existence of POTFILES.in should be enough.