Launchpad itself

Translation template jobs should keep history

Bug #536819 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen
Launchpad itself 10.10

Bug Description

There is no "build" property in IBuildFarmJob, but somehow some things in Soyuz do seem to rely on it—notably builder-index.pt (see bug 536797).

Related branches

lp:~jtv/launchpad/buildfarmjob-getspecificjob-translationtemplatesbuild
Michael Nelson (community): Approve (code)
Diff: 77 lines (+26/-0)
3 files modified
lib/lp/translations/configure.zcml (+6/-0)
lib/lp/translations/model/translationtemplatesbuild.py (+10/-0)
lib/lp/translations/tests/test_translationtemplatesbuild.py (+10/-0)
lp:~jtv/launchpad/536819-display
Paul Hummer (community): Approve (ui)
Henning Eggers (community): Approve (ui*)
Graham Binns (community): Approve (code)
Diff: 1574 lines (+860/-253)
18 files modified
database/sampledata/current-dev.sql (+160/-100)
database/sampledata/current.sql (+170/-100)
database/schema/patch-2208-13-0.sql (+1/-1)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+10/-1)
lib/lp/buildmaster/interfaces/packagebuild.py (+0/-6)
lib/lp/buildmaster/model/buildfarmjob.py (+4/-1)
lib/lp/code/browser/branch.py (+14/-0)
lib/lp/registry/interfaces/productseries.py (+1/-10)
lib/lp/soyuz/browser/configure.zcml (+0/-7)
lib/lp/translations/browser/configure.zcml (+18/-1)
lib/lp/translations/browser/tests/test_translationtemplatesbuild.py (+84/-0)
lib/lp/translations/browser/translationtemplatesbuild.py (+63/-0)
lib/lp/translations/interfaces/translationtemplatesbuild.py (+11/-1)
lib/lp/translations/model/translationtemplatesbuild.py (+46/-10)
lib/lp/translations/model/translationtemplatesbuildjob.py (+5/-1)
lib/lp/translations/stories/buildfarm/xx-build-summary.txt (+89/-4)
lib/lp/translations/templates/translationtemplatesbuild-index.pt (+133/-0)
lib/lp/translations/tests/test_translationtemplatesbuild.py (+51/-10)
Revision history for this message
William Grant (wgrant) wrote :

How to refactor the UI to present multiple build types has not yet been thought through thoroughly. Adding IBuildFarmJob.build is probably not the right way to do it, since TTBJs don't have a build.

Julian Edwards (julian-edwards)
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Michael Nelson (michael.nelson) wrote :

I've tried to summarise this on the existing bug 491330 (Enable a builder to present a generalised history).

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Ok first up, the bug title here is rubbish! Any suggestions to make it better?

Second, my preferred solution is to add a TranslationsBuild, rename the existing Build to BinaryBuild (or BinaryPackageBuild?) and introduce a new BuildFarmJob table that has common attributes for all build farm jobs, such as date, builder and ID. Some careful analysis is needed to see what can be refactored and what is required for the UI work.

The UI should basically drive the requirements here.

tags: added: wellington
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Re-assigning to Translations since they need to implement the build history part now that Michael finished the generalisation work.

summary: - IBuildFarmJob.build
+ Translation template jobs should keep history
affects: soyuz → rosetta
Revision history for this message
Данило Шеган (danilo) wrote :

Can you share a few pointers on how this is done? (where's documentation, eg). Also, how urgent is this?

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in db-stable r9793 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9793>.

Changed in rosetta:
assignee: nobody → Jeroen T. Vermeulen (jtv)
milestone: none → 10.10
tags: added: qa-needstesting
Changed in rosetta:
status: Triaged → Fix Committed
Jeroen T. Vermeulen (jtv)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.