Auto-approve buildfarm-generated templates
Bug #538033 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Henning Eggers | ||
Bug Description
After bug 507680 has been fixed and templates actually make it into the queue, they should be auto-approved immediately. There should be a flag indicating this to the queue when the templates are added. This may share some code with the TranslationsBra
Related branches
lp:~henninge/launchpad/bug-538033-autoapprove
- Jeroen T. Vermeulen (community): Approve
-
Diff: 1295 lines (+726/-172)13 files modifiedlib/lp/code/model/branchjob.py (+1/-2)
lib/lp/translations/doc/translationbranchapprover.txt (+1/-41)
lib/lp/translations/doc/translationbuildapprover.txt (+82/-0)
lib/lp/translations/interfaces/translationimportqueue.py (+12/-8)
lib/lp/translations/model/approver.py (+135/-51)
lib/lp/translations/model/translationimportqueue.py (+62/-34)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+3/-1)
lib/lp/translations/tests/test_translationbranchapprover.py (+26/-27)
lib/lp/translations/tests/test_translationbuildapprover.py (+226/-0)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+19/-8)
lib/lp/translations/utilities/doc/templatenames.txt (+42/-0)
lib/lp/translations/utilities/template.py (+56/-0)
lib/lp/translations/utilities/tests/test_templatenames.py (+61/-0)
| Changed in rosetta: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 10.03 |
| Changed in rosetta: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Henning Eggers (henninge) |
| Changed in rosetta: | |
| milestone: | 10.03 → 10.04 |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10693 <http://