Incorrect display of diff lines starting with +++
Bug #553642 reported by
Josh Holland
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey | ||
Bug Description
When I look at a diff (typically a patch inserted into debian/patches in an Ubuntu package branch) that contains a line starting with a "+", it is not highlighted as the other lines added are. I have attached a screenshot taken from https:/
Related branches
lp:~thumper/launchpad/diff-tales
- Stuart Bishop (community): Approve
-
Diff: 504 lines (+241/-207)3 files modifiedlib/canonical/launchpad/webapp/tests/test_tales.py (+0/-205)
lib/lp/app/browser/stringformatter.py (+10/-2)
lib/lp/app/browser/tests/test_stringformatter.py (+231/-0)
Revision history for this message
| Josh Holland (jshholland) wrote | #1 |
| affects: | launchpad → launchpad-code |
Revision history for this message
| Aaron Bentley (abentley) wrote Re: [Bug 553642] [NEW] Incorrect display of diff lines starting with +++ | #2 |
Revision history for this message
| Josh Holland (jshholland) wrote | #3 |
| tags: | added: code-review confusing-ui trivial |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #4 |
| Changed in launchpad-code: | |
| assignee: | nobody → Tim Penhey (thumper) |
| milestone: | none → 10.06 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
On 04/05/2010 11:04 AM, Launchpad Bug Tracker wrote:
> You have been subscribed to a public bug:
>
> When I look at a diff (typically a patch inserted into debian/patches in
> an Ubuntu package branch) that contains a line starting with a "+", it
> is not highlighted as the other lines added are.
This is no doubt because we want to display the filename indicator lines
of the actual patch (e.g. '+++ debian/changelog') differently from the
insertions and deletions of lines.
Aaron