Consolidate BuildFarmJob interfaces
Bug #562252 reported by
Michael Nelson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Michael Nelson | ||
Bug Description
Currently:
lp.buildmaster.
IBuildFarmJob, ISpecificBuildF
I chatted with Muharem and he said that he can't see a reason why they shouldn't be consolidated onto IBuildFarmJob either.
I'll also switch BuildFarmJob from an inherited mix-in to a delegated object, in preparation for the build generalisation work (where BuildFarmJob will become a concrete Storm class).
Related branches
lp:~michael.nelson/launchpad/delegate-to-buildfarmjob
- Brad Crittenden (community): Approve (code)
-
Diff: 718 lines (+215/-123)15 files modifiedlib/lp/buildmaster/doc/buildfarmjob.txt (+32/-9)
lib/lp/buildmaster/interfaces/buildfarmbranchjob.py (+1/-2)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+15/-25)
lib/lp/buildmaster/model/buildfarmjob.py (+64/-37)
lib/lp/buildmaster/model/packagebuildfarmjob.py (+29/-3)
lib/lp/buildmaster/tests/test_buildqueue.py (+24/-17)
lib/lp/code/configure.zcml (+2/-1)
lib/lp/code/model/sourcepackagerecipebuild.py (+5/-4)
lib/lp/soyuz/configure.zcml (+2/-0)
lib/lp/soyuz/model/binarypackagebuild.py (+1/-3)
lib/lp/soyuz/model/buildpackagejob.py (+11/-5)
lib/lp/soyuz/tests/test_buildpackagejob.py (+13/-0)
lib/lp/translations/configure.zcml (+2/-0)
lib/lp/translations/model/translationtemplatesbuildjob.py (+8/-9)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+6/-8)
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #2 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10756 <http://