Bazaar

possible race condition while creating .bzr.log

Bug #567036 reported by Parth Malwankar
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Invalid
Wishlist
Unassigned

Bug Description

From the merged proposal
https://code.edge.launchpad.net/~parthm/bzr/no-chown-if-bzrlog-exists/+merge/22197

Robert Collins wrote 4 hours ago
> I think this is an improvement. However my experience with race
> conditions is that we always, eventually, run into them.
> So I'd like a new bug filed saying that we have this race and
> should fix it. That can be a wishlist bug, but we know the defect
> exists so lets capture the thinking about it now to save a future
> user having to figure it out.

Parth Malwankar (parthm)
Changed in bzr:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Martin Packman (gz) wrote :

I was under the impression we dealt with this concern with the extra os.open dancing, what still needs doing?

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 567036] Re: possible race condition while creating .bzr.log

I was fairly sure we did a simplistic approach rather than the full mccoy?

Revision history for this message
Martin Pool (mbp) wrote :

What is the actual race condition here?

Revision history for this message
Parth Malwankar (parthm) wrote :

On Wed, Apr 21, 2010 at 5:55 AM, Robert Collins
<email address hidden> wrote:
> I was fairly sure we did a simplistic approach rather than the full
> mccoy?
>

We started with a simple approach but over the discussion
on the merge proposal the solution proposed by Martin [gz]
seems thorough to me. Maybe we should close this?

Revision history for this message
Martin Pool (mbp) wrote :

I don't think there is a bug in the current code. If an old bzr creates the log file it won't be chowned but I don't really see that as a bug.

Changed in bzr:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.