Do not send notifications to registrants (and never if the pillar does not use bugs)

Bug #579502 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Brad Crittenden

Bug Description

In the process of organisiing ~registry, I see why team members were complaining about email noise.

Note this footer:
    Please remove python-gtkhtml2 from package dependencies
    https://bugs.launchpad.net/bugs/538773
    You received this bug notification because you are a member of Registry
    Administrators, which is the registrant for Debian.

^ Registrants should not be punished for helping others. Registrants do not get emails!
^ Debian does not use Launchpad for bug tracking...~registry should not be getting bug email.

Related branches

Revision history for this message
Curtis Hovey (sinzui) wrote :

After reviewing several emails I can see most, may all, the emails for because of other-distributions. ~registry is the owner of all distros except for 3, but unknowledgable user target bugs to tis distros. They do not use launchpad, and not that users cannot register them. Admins register them then either give them to a user (who can choose to enable bugs) or gives them to ~regisrty, (it will never use bugs).

The best fix for this issue is to honour official_malone in the case of distros. reject the owner recipent if the disrto does not use Launchpad bugs.

Graham Binns (gmb)
Changed in malone:
status: New → Triaged
importance: Undecided → Medium
tags: added: story-better-bug-notification
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi graham,

Looking in a stale version of canonical/launchpad/mailnotifications.py, this is the code that I believe is wrong:

    # If the target's bug supervisor isn't set,
    # we add the owner as a subscriber.
    pillar = bugtask.pillar
    if pillar.bug_supervisor is None:
        also_notified_subscribers.add(pillar.owner)
        if recipients is not None:
            recipients.addRegistrant(pillar.owner, pillar)

^ Launchpad should check that pillar.official_malone before adding owner or bug_supervisor. The first because the user is probably the registrant, the second because the supervisor is the upstream bug contact for many mirrored projects. Now we may think that he second point is wrong...we do want to send the upstream bug contact an email. I think in general, a project must use lp to track bugs for lp to consider forcing users into subscriber lists.

Curtis Hovey (sinzui)
tags: added: bugjam2010
Brad Crittenden (bac)
Changed in launchpad:
assignee: nobody → Brad Crittenden (bac)
status: Triaged → In Progress
Revision history for this message
Brad Crittenden (bac) wrote :

In the previous comments about this bug it was limited to distributions. The fix should actually be applied for all pillars.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.01
Brad Crittenden (bac)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.