Launchpad itself

On-demand builds should be limited.

Bug #581901 reported by Aaron Bentley
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Aaron Bentley
Launchpad itself 10.07

Bug Description

jml says that on-demand package builds should be limited, to avoid DOSing the build farm and wasting resources. We should discuss what kind of restriction is reasonable with soyuz.

Related branches

lp:~abentley/launchpad/build-quota
Paul Hummer (community): Approve (code)
Diff: 330 lines (+133/-5)
10 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+11/-0)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+20/-0)
lib/lp/code/interfaces/sourcepackagerecipe.py (+23/-1)
lib/lp/code/model/sourcepackagerecipe.py (+11/-1)
lib/lp/code/model/sourcepackagerecipebuild.py (+12/-0)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+17/-1)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+30/-0)
lib/lp/registry/interfaces/distroseries.py (+3/-0)
lib/lp/registry/model/distroseries.py (+3/-0)
lib/lp/testing/factory.py (+3/-2)
Aaron Bentley (abentley)
tags: added: recipe
Aaron Bentley (abentley)
Changed in launchpad-code:
status: Fix Committed → Triaged
Revision history for this message
Aaron Bentley (abentley) wrote :

One obvious limit is that you can't schedule a build while an identical build is in the queue.

Revision history for this message
Jonathan Lange (jml) wrote :

In an ideal world, we'd have a limit based on cost. I hear that's pretty tricky, so we could settle for something less rigorous for now.

Revision history for this message
Aaron Bentley (abentley) wrote :

I suggested 5-10 to bigjools, and he thought that was fine, as long as we mark the service as "beta".

He also requested that we promote local testing, rather than using the build farm for trying out recipes. I'll discuss that with dholbach. Local testing may be problematic for some upstreams who use different distros. Perhaps they would use EC2/UEC?

Revision history for this message
Aaron Bentley (abentley) wrote :

Another alternative would be to not have a hard limit, but reduce the score of each consecutive rebuild, so that they don't interfere with other people.

Aaron Bentley (abentley)
Changed in launchpad-code:
status: Triaged → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10983 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10983>

Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
milestone: none → 10.06
tags: added: qa-needstesting
Aaron Bentley (abentley)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.