Launchpad itself

BuildBase result handling broken

Bug #587113 reported by William Grant
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Nelson
Launchpad itself 10.07

Bug Description

Since the Great IPackageBuild Refactor, attempting to handle a complete recipe build dies like this:

2010-05-29 11:05:45+1000 [-] Traceback (most recent call last):
2010-05-29 11:05:45+1000 [-] File "/home/wgrant/launchpad/lp-branches/db-devel/lib/lp/buildmaster/model/buildfarmjobbehavior.py", line 115, in updateBuild
2010-05-29 11:05:45+1000 [-] method(queueItem, slave_status, logtail, logger)
2010-05-29 11:05:45+1000 [-] File "/home/wgrant/launchpad/lp-branches/db-devel/lib/lp/buildmaster/model/buildfarmjobbehavior.py", line 187, in updateBuild_WAITING
2010-05-29 11:05:45+1000 [-] build.handleStatus(build_status, librarian, slave_status)
2010-05-29 11:05:45+1000 [-] TypeError: handleStatus() takes exactly 4 arguments (3 given)

BuildBase.handleStatus should not itself be static.

Tags: lp-soyuz qa-ok

Related branches

lp:~michael.nelson/launchpad/587113-buildbase-handleStatus
Graham Binns (community): Approve (code)
Diff: 531 lines (+198/-69)
10 files modified
lib/canonical/launchpad/webapp/configure.zcml (+1/-1)
lib/canonical/launchpad/webapp/tales.py (+2/-2)
lib/lp/buildmaster/interfaces/buildbase.py (+27/-12)
lib/lp/buildmaster/model/buildbase.py (+24/-13)
lib/lp/buildmaster/model/packagebuild.py (+2/-2)
lib/lp/buildmaster/tests/test_buildbase.py (+76/-35)
lib/lp/code/model/sourcepackagerecipebuild.py (+7/-1)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+31/-1)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+23/-0)
lib/lp/testing/factory.py (+5/-2)
Revision history for this message
William Grant (wgrant) wrote :

Once that's fixed, the method(..) call fails (since those methods are now static). The attached patch makes it mostly work.

Julian Edwards (julian-edwards)
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Michael Nelson (michael.nelson)
Revision history for this message
Michael Nelson (michael.nelson) wrote :

It was made temporarily static while we are transitioning the other build types to the new infrastructure, so that builds of both the new infrastructure (BinaryPackageBuild) and the old (SourcePackageReceipeBuild) can share the same implementation (and tests).

The shared implementation on BuildBase needs to be factored out into a function so that IBuildBase.updateStatus() itself does not require the build attribute.

Changed in soyuz:
status: Triaged → In Progress
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Sorry - I've got to focus on 588684... will get back to this as soon as that's done.

Changed in soyuz:
status: In Progress → Triaged
Michael Nelson (michael.nelson)
Changed in soyuz:
status: Triaged → In Progress
Michael Nelson (michael.nelson)
Changed in soyuz:
milestone: none → 10.06
Revision history for this message
Michael Nelson (michael.nelson) wrote :

This landed devel r10970.

Changed in soyuz:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10970 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10970>

tags: added: qa-needstesting
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Ran both SPRecipe builds and a non-virtual distro build through df using db-devel 9444.

tags: added: qa-ok
removed: qa-needstesting
Michael Nelson (michael.nelson)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.