packaging portlet cause timeout on distroseries index

Bug #612358 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Robert Collins

Bug Description

OOPS-1673S138 and OOPS-1673S140 show that the timeout issue is not fixed on staging, and the oops continue to appear on edge.

To QA this, visit a distroseries - e.g. /ubuntu/lucid - and it should not time out, and should show the number of linked packages.

Related branches

Curtis Hovey (sinzui)
tags: added: bridging-the-gap
Curtis Hovey (sinzui)
summary: - packing portlet cause timeout on distroseries index
+ packaging portlet cause timeout on distroseries index
j.c.sackett (jcsackett)
Changed in launchpad-registry:
assignee: nobody → j.c.sackett (jcsackett)
status: Triaged → In Progress
j.c.sackett (jcsackett)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Robert Collins (lifeless) wrote :

Still saw timeouts in this on sunday: https://lp-oops.canonical.com/oops.py/?oopsid=1681EB3871

However, this may *not* be the packaging portlet.

The oops traceback shows the portlet, *but* the timeout is triggering on the first storm query *after* 15 seconds of non-sql activity.

So, the packaging portlet may simply be *the first thing showing after the bad code* : we need to look more deeply.

Changed in launchpad-registry:
status: Fix Committed → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

It is the packaging portlet. It is querying the total number of linked packages in the series to state how much has been done. I reported a bug about an issue. Sundays oopes was reported as bug 615064 distroseries+index oops getMostRecentlyLinkedPackagings(), but my recent thoughts (guided by Edwin) the count of packages (we only want a number) caused the issue.

Changed in launchpad-registry:
milestone: 10.08 → 10.09
Revision history for this message
Robert Collins (lifeless) wrote :

Its amazing to me that deserialising 2155 rows could cause 16 seconds of python time !

Nevertheless, I've switched packagings into a DecoratedResultSet which should help, as query time wasn't a concern in the oops we see at the moment.

description: updated
Revision history for this message
Robert Collins (lifeless) wrote :

I've checked that this succeeds on staging at https://staging.launchpad.net/ubuntu/lucid, and it worked first time.\o/

    At least 143 queries issued in 4.97 seconds

    r9646

Changed in launchpad-registry:
status: In Progress → Fix Committed
tags: added: qa-ok
Revision history for this message
Robert Collins (lifeless) wrote :

    At least 114 queries issued in 0.92 seconds

for a refresh.

Changed in launchpad-registry:
milestone: 10.09 → 10.08
assignee: j.c.sackett (jcsackett) → Robert Collins (lifeless)
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
tags: added: qa-needstesting
removed: qa-ok
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 612358 Fix released

Fixed released in launchpad-project 10.08.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.