cronscripts/request_daily_builds.py is not verbose enough on default logging
Bug #619555 reported by
Steve McInerney
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey | ||
Bug Description
A complete run:
2010-08-17 23:52:17 INFO Creating lockfile: /var/lock/
2010-08-17 23:52:42 INFO Requested 118 daily builds.
That's it. just the 2 lines.
As a minimum, it'd be good to get a 'Deleting locking' message to easily note the script ending; otherwise it's a bit on the guess work side.
I assume, that -v++ options would give more details on the builds kicked off.
Given this is the default setting, it *may* be useful for basic debug to display what builds are kicked off?
Or we can add a -v or more to the cron entry for same?
Related branches
lp:~thumper/launchpad/bugjam-619555-request-builds-logging
- Edwin Grubbs (community): Approve (code)
- Benji York (community): Approve (code*)
-
Diff: 115 lines (+31/-5)6 files modifiedcronscripts/request_daily_builds.py (+1/-1)
lib/canonical/launchpad/scripts/logger.py (+4/-0)
lib/lp/code/interfaces/sourcepackagerecipebuild.py (+5/-2)
lib/lp/code/model/sourcepackagerecipebuild.py (+5/-1)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+13/-0)
lib/lp/testing/logger.py (+3/-1)
| tags: | added: canonical-losa-lp |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | added: recipe |
Revision history for this message
| Tim Penhey (thumper) wrote | #1 |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Tim Penhey (thumper) |
| tags: | added: bugjam2010 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
To post a comment you must log in.
Steve, the lock file removal is logged at the debug level (don't ask why, it is in contrib/glock.py). If you want this logged at INFO like the lockfile acquisition, please file a separate bug as that will require changing heaps of tests :-(
I've updated the code in the related branch to log at debug level the recipes that are having the build requested. If you want this recorded in our logfiles, you should at a -v to the cron job.