bzrdir.destroy_workingtree ignores conflicts (which means that subtree support is broken for treeless branches)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned |
Bug Description
The implementation of bzrdir.
wt = self.open_
repository = wt.branch.
empty = repository.
That is, it calls wt.revert() and happily ignores any resulting
conflicts (returned by revert). This is not totally wrong since
we're about to delete the wt metadata anyway and all that should
be left here are detritus.
I encounter this while working on bug #323111 where
bzrlib.
started to fail.
Specifically, the ignored conflict is:
[DeletingPar
subtree being a tree reference.
So indeed in this case, we leave some detritus: 'subtree' and 'subtree/.bzr'.
Orphaning 'subtree' in this case means really get rid of the 'subtree/.bzr' dir.
The test now fails when it tries to sprout() because 'subtree/.bzr' is not there anymore.
Which means that is was passing before because detritus where lying around.
I will turn it into an expected failure into my merge proposal and refer to this bug.
summary: |
- bzrdir.destroy_workingtree ignores conflicts + bzrdir.destroy_workingtree ignores conflicts (which means that subtree + support is broken for treeless branches) |
Changed in bzr: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
tags: | added: workingtree |
tags: | added: subtrees |
tags: | added: check-for-breezy |