Stop loading the entire ancestry of a branch during the scan
Bug #638637 reported by
Tim Penhey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
Bug Description
The branch scanner loads the entire ancestry during the scan for every branch on every scan from both bzrlib and from the database. We need to be smarter here. This is causing time-outs and lock contention.
Related branches
lp:~abentley/launchpad/partial-ancestry-scanner
- Paul Hummer (community): Approve
-
Diff: 553 lines (+193/-117)7 files modifiedlib/lp/codehosting/bzrutils.py (+12/-0)
lib/lp/codehosting/scanner/bzrsync.py (+84/-57)
lib/lp/codehosting/scanner/events.py (+3/-2)
lib/lp/codehosting/scanner/mergedetection.py (+4/-4)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+83/-33)
lib/lp/codehosting/scanner/tests/test_mergedetection.py (+3/-3)
lib/lp/testing/factory.py (+4/-18)
Revision history for this message
| Aaron Bentley (abentley) wrote | #2 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| milestone: | none → 10.11 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've removed the timeout tag for now, though this is definitely important, its not fully confirmed as being the cause of user timeouts.