BinaryPackagePublishingHistory._getOtherPublications fails to restrict the distroseries context

Bug #653382 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant

Bug Description

The recent Stormification of BinaryPackagePublishingHistory._getOtherPublications incorrectly said:

  BinaryPackagePublishingHistory.distroarchseries in available_architectures

This unobviously evaluates to True (possibly because Reference.__eq__ returns a Storm expression, which evaluates to True). The correct syntax is this:

  BinaryPackagePublishingHistory.distroarchseriesID.is_in(available_architectures)

The constant evaluation to True means that architecture-independent binary domination ignores the context series, dominating everything in the same archive, pocket and overrides. This indicates missing tests both before and after I rewrote them.

Tags: lp-soyuz qa-ok

Related branches

William Grant (wgrant)
Changed in soyuz:
assignee: nobody → William Grant (wgrant)
status: New → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
Changed in soyuz:
milestone: none → 10.10
tags: added: qa-needstesting
Changed in soyuz:
status: In Progress → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
Changed in soyuz:
importance: Undecided → High
importance: High → Critical
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.