[maverick] It is hard to read highlighted names of paused torrents in default desktop theme

Bug #663848 reported by Ivan Kharlamov
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
light-themes (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: transmission

Grey font of paused torrents is unreadable if highlighted in Ubuntu 10.10 default theme (Ambiance, Radiance).

It is also unreadable with lots of custom desktop themes. I suggest you to stop hard-coding "paused" font color or to stop inheriting Gnome selection background.

Right now Transmission inherits only one parameter: selection background, and the "paused" font color is hard-coded in the app. Needless to say, both color parameters(font color and background color) are only useful when they correlate with each other.

--
I run Transmission 2.11 (11322) and Ubuntu 10.04 with desktop themes from Ubuntu 10.10(ppa:murrine-daily).

Revision history for this message
Ivan Kharlamov (the-paper-men) wrote :
Revision history for this message
Charles Kerr (charlesk) wrote :

Hi Ivan,

Thanks for reporting this issue. I'm not sure what you mean when you say Transmission uses one parameter but not others -- the cell render code for that list doesn't specify any colors at all, so it should all be coming from the theme. When you refer to parameters is there a specific piece of code that you're looking at, or are you referring to what you're seeing when you apply different themes to Transmission while running?

Revision history for this message
Charles Kerr (charlesk) wrote :

After looking through the code again, Transmission isn't using any custom colors at all. I think the issue you're seeing is coming from the theme rather than Transmission.

Reassigning to light-themes to get a second opinion from the themes camp.

Also, this appears to be similar to bug #536989.

affects: transmission (Ubuntu) → light-themes (Ubuntu)
Revision history for this message
Ivan Kharlamov (the-paper-men) wrote :

Hi, Charles, sorry for being too vague. At the time I was writing this report I didn't look at the code, I just switched between few pre-installed Ubuntu themes and watched highlighted paused torrents in Transmission active window.

Now I realize that I've made a wrong guess about hardcoded foreground colour. Now I see that there is really nothing hardcoded except red color for torrents with errors.

I still think that you've got something to do with theme issue.

I've switched between all preinstalled Ubuntu themes and 4 out of 8 of them showed not very pleasant results(See attachment below). And if you won't count high-contrast themes which IMHO are rarely used, you'll get unpleasant result with 4/6 probability.

Revision history for this message
Charles Kerr (charlesk) wrote :

> I've switched between all preinstalled Ubuntu themes and 4 out of 8 of them showed not very pleasant results(See attachment below).

In that attachment, three of the four themes rely on the Murrine engine which is why I say this is similar to bug #536989.

> I still think that you've got something to do with theme issue.

I'm at a loss to see how. https://trac.transmissionbt.com/browser/trunk/gtk/torrent-cell-renderer.c is the Transmission code that does the renderering for these screenshots. As you can see, there are two GtkCellRendererTexts -- one for errors, and one for non-errors. In the error case we /do/ set the foreground to red, but that is the only place where any colors are set anywhere in the code. All other colors come from the theme.

Revision history for this message
Ivan Kharlamov (the-paper-men) wrote :

> I'm at a loss to see how.
OK maybe It's a dumb idea, but you can calculate the difference between foreground and background color and change inherited foreground color if difference meets certain conditions. :)
Or you can rely on other colors of the theme...

Seriously, I'm not a fan of theme stuff and usually use defaults, but I saw exactly the same problem few times before on other machines with popular custom themes. And that was few years ago, probably before Murrine was developed.

Revision history for this message
Ivan Kharlamov (the-paper-men) wrote :

Charles, I understand that it's not a serious issue at all and I didn't mean to waste your time. Transmission is a great application and I highly appreciate your work!

Revision history for this message
Charles Kerr (charlesk) wrote :

Ivan, you're not wasting my time. I'm just trying to make sure I get this ticket into the hands of people who can triage it properly. :)

Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

This problem still happens?

Changed in light-themes (Ubuntu):
status: New → Incomplete
Revision history for this message
Ivan Kharlamov (the-paper-men) wrote :

@Fitoschido, I've just checked and the bug is still there. Don't know whether it's worth fixing if it only affects Maverick, but yes, it is there.

Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

Hm. Well, at least this do not happen anymore in Oneiric (Transmission GTK3).

Changed in light-themes (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Andrea Cimitan (cimi) wrote :

Fixed in 12.04 I think

Changed in light-themes (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.