Launchpad itself

FixReleased should be locked against reopening

Bug #664096 reported by Deryck Hodge
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Deryck Hodge
Launchpad itself 10.11 "Tenacious Turkey"

Bug Description

The bug task status FixReleased should be locked so that only bug supervisor or the original reporter can transition a bug away from FixReleased.

Tags: lp-bugs qa-ok

Related branches

lp:~deryck/launchpad/better-testing-for-status-changes
Abel Deuring (community): Approve (code)
Diff: 534 lines (+366/-146)
2 files modified
lib/lp/bugs/doc/bugtask-status-changes.txt (+51/-131)
lib/lp/bugs/tests/test_bugtask_status.py (+315/-15)
lp:~deryck/launchpad/lock-fix-released-status-126516
Jelmer Vernooij (community): Approve (code)
Diff: 252 lines (+69/-21)
11 files modified
lib/lp/bugs/browser/tests/bugs-views.txt (+1/-1)
lib/lp/bugs/doc/bugtask.txt (+1/-1)
lib/lp/bugs/doc/displaying-bugs-and-tasks.txt (+1/-1)
lib/lp/bugs/doc/malone-karma.txt (+1/-1)
lib/lp/bugs/model/bugtask.py (+4/-3)
lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt (+3/-2)
lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt (+10/-0)
lib/lp/bugs/tests/bugs-emailinterface.txt (+8/-8)
lib/lp/bugs/tests/test_bugtask_1.py (+4/-2)
lib/lp/bugs/tests/test_bugtask_status.py (+34/-0)
lib/lp/soyuz/doc/closing-bugs-from-changelogs.txt (+2/-2)
lp:~deryck/launchpad/allow-reporter-fixed-released-unsetting-664096
Gavin Panella (community): Approve
Diff: 98 lines (+52/-8)
2 files modified
lib/lp/bugs/model/bugtask.py (+8/-5)
lib/lp/bugs/model/tests/test_bugtask_status.py (+44/-3)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11754 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11754>.

Changed in malone:
milestone: none → 10.11
tags: added: qa-needstesting
Changed in malone:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Incremental fix

r11785 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11785) is part of this bug's fix.

Deryck Hodge (deryck)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Robert Collins (lifeless) wrote :

Garh incremental branches.

Changed in malone:
status: In Progress → Fix Released
status: Fix Released → In Progress
tags: removed: qa-ok
tags: added: qa-needstesting
Robert Collins (lifeless)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11849 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11849>.

tags: added: qa-needstesting
removed: qa-ok
Changed in malone:
status: In Progress → Fix Committed
Deryck Hodge (deryck)
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in malone:
status: Fix Committed → Fix Released
Revision history for this message
Oliver Grawert (ogra) wrote :

what is the justification for that change ? it would be really nice to put the reason that caused such a decision into the bug description, note that there are teams with only one supervisor (but a bunch of developers that work on bugs without being supervisors) with that change you add an artificial bottleneck to such teams (and put extra paperwork onto the bug supervisor).

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 664096] Re: FixReleased should be locked against reopening

@Oliver contentious bugs in high volume projects/packages suffer when
a bug looks superficially like a users symptoms and they say 'hey,
this has regressed' - e.g., 'black screen on boot' : yet there can be
hundreds of discrete causes causing that symptom.

Is it unreasonable to have a team as bug supervisor if you want to
allow a wide spread of developers to do anything with bugs. Note too
that the original bug *filer* will be able to un-release a bug : after
all they are the person with the original symptoms.

Revision history for this message
Martin Pool (mbp) wrote :

@ogra https://bugs.launchpad.net/launchpad/+bug/887875 for problems caused by this approach.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.