Launchpad itself

ProjectGroup:+milestones timeouts

Bug #669724 reported by Robert Collins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Edwin Grubbs
Launchpad itself 11.02

Bug Description

No OOPS id yet, the page was swamped on the OOPS report, however its in the top timeout array. (See the oops id grouping bugs ;().

Related branches

lp:~edwin-grubbs/launchpad/bug-669724-projectgroup-milestones-timeout
Curtis Hovey (community): Approve (code)
Diff: 271 lines (+46/-31)
7 files modified
lib/lp/bugs/doc/official-bug-tags.txt (+10/-5)
lib/lp/registry/browser/configure.zcml (+2/-2)
lib/lp/registry/browser/milestone.py (+10/-6)
lib/lp/registry/browser/project.py (+9/-5)
lib/lp/registry/model/projectgroup.py (+9/-6)
lib/lp/registry/stories/milestone/object-milestones.txt (+1/-2)
lib/lp/registry/templates/object-milestones.pt (+5/-5)
Robert Collins (lifeless)
Changed in launchpad-registry:
status: New → Triaged
importance: Undecided → High
tags: added: timeout
Revision history for this message
Curtis Hovey (sinzui) wrote :

How is this oops different from bug 638924 ? Every milestone timeout I have seen is about people and bugs. There only difference between ProjectGroup, Distribution, and Project Milestone pages are the columns in the listing.

Changed in launchpad-registry:
status: Triaged → Incomplete
Revision history for this message
Robert Collins (lifeless) wrote :

Fixing one /may/ fix them all. However due to the nature of zope routing and the unsafety of eager loading everywhere, we can't be sure that fixing one will fix them all. So a separate bug is appropriate.

Changed in launchpad-registry:
status: Incomplete → Triaged
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → series-future
Robert Collins (lifeless)
Changed in launchpad:
importance: High → Critical
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Which projectgroup +milestone is having oopses still?

Revision history for this message
Curtis Hovey (sinzui) wrote :

https://devpad.canonical.com/~lpqateam/lpnet-temp-test.html is always available to see the latest issues. There is an archive directly too. Today we have:
    https://launchpad.net/openobject/+milestones
    https://launchpad.net/launchpad-project/+milestones
    https://launchpad.net/ayatana/+milestones

Edwin Grubbs (edwin-grubbs)
Changed in launchpad:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
milestone: none → 11.02
status: Triaged → In Progress
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

The +milestones page for distributions and projects does not included the bugtask counts or spec counts, and it looks like it was merely an oversight to turn that off for project groups. I will remove the counts, which should solve the timeouts. I will also eliminate some redundant queries although they have negligible impact.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 669724] Re: ProjectGroup:+milestones timeouts

Should be able to do one query for all counts efficiently... If the counts
area nice ui wise

On 15/01/2011 1:41 PM, "Edwin Grubbs" <email address hidden> wrote:

The +milestones page for distributions and projects does not included
the bugtask counts or spec counts, and it looks like it was merely an
oversight to turn that off for project groups. I will remove the counts,
which should solve the timeouts. I will also eliminate some redundant
queries although they have negligible impact.

--

You received this bug notification because you are a direct subscriber
of the bug.
https://bugs.laun...
Title:
 ProjectGroup:+milestones timeouts

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r12238 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12238>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Edwin Grubbs (edwin-grubbs)
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.