has_existing_ppa and has_ppa_with_published_packages should not be on IPerson
Bug #693357 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Brad Crittenden | ||
Bug Description
has_existing_ppa and has_ppa_
that Soyuz-specific queries are kept in the lp.soyuz domain.
The Bugs team made this mistake with one of their bits of code that knows too much about Soyuz publishing tables and caused circular imports when running bin/test. It also makes future changes to Soyuz code harder because the developer will not expect this sort of code to be outside the Soyuz domain.
I recommend:
IPerson.
IPerson.
Related branches
lp:~bac/launchpad/bug-693357
- Curtis Hovey (community): Approve (code)
- j.c.sackett (community): Approve (code*)
-
Diff: 644 lines (+156/-99)7 files modifiedlib/lp/registry/browser/peoplemerge.py (+7/-2)
lib/lp/registry/browser/person.py (+7/-2)
lib/lp/registry/interfaces/person.py (+1/-11)
lib/lp/registry/model/person.py (+5/-26)
lib/lp/soyuz/doc/archive.txt (+118/-50)
lib/lp/soyuz/interfaces/archive.py (+9/-5)
lib/lp/soyuz/model/archive.py (+9/-3)
| tags: | added: tech-debt |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: ppa users |
| Changed in launchpad: | |
| importance: | Low → High |
| tags: | added: lp-soyuz |
| Changed in launchpad: | |
| assignee: | nobody → Brad Crittenden (bac) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12157 <http://