Launchpad itself

Implement direct lifecycle subscriptions

Bug #711901 reported by Данило Шеган
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Данило Шеган
Launchpad itself 11.02

Bug Description

This is part of on-going work to enable better bug subscriptions.

Implement BugNotificationLevel.LIFECYCLE subscription level for direct subscriptions so people only get emails on bug being opened or bug being closed.

Related branches

lp:~danilo/launchpad/lifecycle-subscription
Graham Binns (community): Approve (code)
Diff: 599 lines (+393/-36)
9 files modified
lib/lp/app/widgets/__init__.py (+0/-2)
lib/lp/bugs/adapters/bugchange.py (+65/-1)
lib/lp/bugs/adapters/tests/test_bugchange.py (+179/-21)
lib/lp/bugs/interfaces/bugchange.py (+2/-0)
lib/lp/bugs/interfaces/bugtask.py (+0/-7)
lib/lp/bugs/model/bug.py (+1/-1)
lib/lp/bugs/subscribers/bug.py (+8/-1)
lib/lp/bugs/subscribers/tests/test_bug.py (+132/-0)
lib/lp/bugs/tests/test_bugchanges.py (+6/-3)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12316 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12316>.

Changed in launchpad:
milestone: none → 11.02
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Данило Шеган (danilo) wrote :

If there's only a direct subscription, it works correctly. If there is a structural subscription (in my example, I was subscribed to both a bug directly [on LIFECYCLE level] and structurally on the product), it may mask the direct subscription.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Данило Шеган (danilo) wrote :

My test to make sure structural subscriptions do not mask direct LIFECYCLE subscriptions in such a case at:

  http://pastebin.ubuntu.com/562683/

Because it's EOW, I didn't bother making a proper minimal test (because that would probably mean almost fixing the code as well), but it is end-to-end integration test. One can see that it already passes today if assertRecipients includes self.product_metadata_subscriber.

Revision history for this message
Данило Шеган (danilo) wrote :

Oh, also, the test case actually uses some helpers from my lp:~danilo/launchpad/bug-584-use-preference branch, simply because that had everything already set-up for end-to-end testing.

Gary Poster (gary)
tags: added: story-better-bug-notification
Revision history for this message
William Grant (wgrant) wrote :

This fix has been deployed, but I'm not sure if this bug is complete.

Revision history for this message
Gary Poster (gary) wrote :

bug 713382 tracks the issue Danilo describes. I'll mark this one as released.

Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.