Launchpad itself

Rewrite lp.client tests using yuitest

Bug #724609 reported by Francis J. Lacoste
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Gary Poster

Bug Description

The canonical/launchpad/windmill/jstests/launchpad_ajax.js are not tested automatically. They are the only tests using the JavaScript testing functionality of windmill. Since they are not run automatically, these tests have bitrotten. I get between 12 and 21 failures depending on the test run. And that's when they are able to be completed.

They use a form of SynchronizedTest that always exposed regressions in the windmill stack back in the days when it was developped.

We should port those tests to the yuitest framework. The YUI test will need scaffolding because they should run with a running app server unlike the other yui test. (Which actually run with an app server as they are run in the Windmill Layer, but they can also be run standalone.)

This replaces bug 680497

Related branches

lp:~gary/launchpad/yuixhr
Deryck Hodge (community): Approve (code)
Diff: 1888 lines (+1470/-65)
18 files modified
Makefile (+15/-11)
configs/testrunner-appserver/yuitest.zcml (+2/-2)
configs/testrunner/yuitest.zcml (+16/-0)
lib/canonical/launchpad/scripts/runlaunchpad.py (+62/-6)
lib/canonical/testing/ftests/test_layers.py (+4/-4)
lib/canonical/testing/layers.py (+36/-10)
lib/lp/app/javascript/server_fixture.js (+65/-0)
lib/lp/testing/__init__.py (+23/-10)
lib/lp/testing/_login.py (+12/-7)
lib/lp/testing/tests/test_login.py (+14/-1)
lib/lp/testing/tests/test_standard_yuixhr_test_template.js (+64/-0)
lib/lp/testing/tests/test_standard_yuixhr_test_template.py (+154/-0)
lib/lp/testing/tests/test_yuixhr.py (+391/-0)
lib/lp/testing/tests/test_yuixhr_fixture.js (+175/-0)
lib/lp/testing/tests/test_yuixhr_fixture.py (+102/-0)
lib/lp/testing/views.py (+0/-12)
lib/lp/testing/yuixhr.py (+331/-0)
setup.py (+4/-2)
lp:~gary/launchpad/bug724609
Brad Crittenden (community): Approve
Diff: 709 lines (+539/-19)
8 files modified
lib/lp/app/javascript/client.js (+18/-9)
lib/lp/app/javascript/server_fixture.js (+67/-1)
lib/lp/app/javascript/tests/test_lp_client.js (+48/-0)
lib/lp/app/javascript/tests/test_lp_client_integration.js (+333/-0)
lib/lp/app/javascript/tests/test_lp_client_integration.py (+62/-0)
lib/lp/app/templates/base-layout-macros.pt (+6/-2)
lib/lp/registry/browser/tests/test_subscription_links.py (+2/-6)
lib/lp/testing/__init__.py (+3/-1)
Francis J. Lacoste (flacoste)
Changed in launchpad:
importance: High → Critical
Gary Poster (gary)
Changed in launchpad:
assignee: nobody → Gary Poster (gary)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14015 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14015) is part of this bug's fix.

tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → In Progress
Gary Poster (gary)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14351 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14351>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Francis J. Lacoste (flacoste)
tags: added: qa-untestable
removed: qa-needstesting
Raphaël Badin (rvb)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.