I get lp bug mail even though 'on own actions' turned off

Hi Robert. Do you have a copy of one of the incorrectly-sent notifications you can attach here? I have a hypothesis that I'd like some evidence for.

Thanks.

I can't reproduce the bug. I have scoured the code to find a way that this can happen and -- despite a couple of false hopes -- haven't been successful.

Another case; just retargeted a bug from lp to bzr; mail headers:

Delivered-To: <my personal email>
Received: by 10.231.157.73 with SMTP id a9cs4764ibx;
        Fri, 8 Apr 2011 22:50:45 -0700 (PDT)
Received: by 10.216.62.73 with SMTP id x51mr2575566wec.64.1302328243951;
        Fri, 08 Apr 2011 22:50:43 -0700 (PDT)
Return-Path: <email address hidden>
Received: from adelie.canonical.com (adelie.canonical.com [91.189.90.139])
        by mx.google.com with ESMTP id h47si6913069wer.180.2011.04.08.22.50.43;
        Fri, 08 Apr 2011 22:50:43 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of <email address hidden> designates 91.189.90.139 as permitted sender) client-ip=91.189.90.139;
Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of <email address hidden> designates 91.189.90.139 as permitted sender) <email address hidden>
Received: from soybean.canonical.com ([91.189.89.57])
 by adelie.canonical.com with esmtp (Exim 4.71 #1 (Debian))
 id 1Q8R4C-0000O5-7F
 for <my personal email>; Sat, 09 Apr 2011 05:50:40 +0000
Received: from soybean.canonical.com (localhost [127.0.0.1])
 by soybean.canonical.com (Postfix) with ESMTPS id 2304C32204E
 for <my personal email>; Sat, 9 Apr 2011 05:50:40 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Date: Sat, 09 Apr 2011 05:50:36 -0000
From: Launchpad Bug Tracker <email address hidden>
To: <my personal email>
Reply-To: Bug 89059 <email address hidden>
Sender: <email address hidden>
X-Launchpad-Bug: product=bzr; status=Triaged; importance=Medium; assignee=None;
X-Launchpad-Bug-Tags: codehosting-ssh
X-Launchpad-Bug-Private: no
X-Launchpad-Bug-Security-Vulnerability: no
X-Launchpad-Bug-Commenters: jelmer lifeless mbp sistpoty
X-Launchpad-Bug-Reporter: StefanPotyra (sistpoty)
X-Launchpad-Bug-Modifier: Robert Collins (lifeless)
References: <email address hidden>
Subject: [Bug 89059] [NEW] remove older bzr revisions on bazaar.launchpad.net
X-Launchpad-Message-Rationale: Subscriber (Bazaar) @bzr-core
Message-Id: <email address hidden>
Errors-To: <email address hidden>
Precedence: bulk
X-Generated-By: Launchpad (canonical.com); Revision="12757";
 Instance="launchpad-lazr.conf"
X-Launchpad-Hash: 0ab88f438ad112189811465c174be99c154cc2fb

You have been subscribed to a public bug:

bzr-core is subscribed; I'm a member of bzr-core. I'm guessing that emy doing this action was lost skipping the 'you should receive' code path or something like that.

I'm pretty sure the other case of my own actions triggering mail is bug branch linking.

It surprises me that the From address is
Launchpad Bug Tracker <email address hidden>" instead of
"Robert Collins <email address hidden>" (like the email I received
when Robert posted to this bug).

My reading of get_bugmail_from_address suggests that this is because the
janitor celebrity is the value of "actor" in
construct_email_notifications. If so, that would cause Robert to get an
email about the change, but I can't figure out how that would happen.

FWIW I did the retargeting in the web ui using the expandable form (because of the ajax vocabulary problem with project picking)

Fixed in stable r12952 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12952>.