JS syntax checking is broken in packaging
Bug #742619 reported by
Benji York
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Unassigned | ||
| pocket-lint |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Some browsers (IE in particular) can't handle trailing commas on the last element of a list or object literal. Our linter (as invoked by "make lint" doesn't' report such trailing commas.
To reproduce open up a JS file (e.g., lib/lp/
| affects: | launchpad → pocket-lint |
| Changed in pocket-lint: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in pocket-lint: | |
| milestone: | none → 0.5.6 |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #2 |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #3 |
| Changed in pocket-lint: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Curtis Hovey (sinzui) |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #4 |
| Changed in pocket-lint: | |
| status: | In Progress → Fix Committed |
| summary: |
- "make lint" doesn't compaint about trailing commas + JS syntax checking is broken in packaging |
| Changed in pocket-lint: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → Fix Released |
| Changed in pocket-lint: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
I think the JavascriptChecker is no longer passing the the arguments are not being passed correctly to js interpreter. I will explore the command directly to determine what the python needs to do when calling the subproc.