Question.get*Recipients could be cached

Bug #769160 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Curtis Hovey

Bug Description

There are several bugs tracking timeouts caused by sending emails. While we want to send emails out of proc, there is an immediate benefit to reducing the cost of repetitive queries building the recipients. All the call sites of the recipient methods are working with static data; is cannot change once the set is built. All the callsites use this data after the subscriber set could have changed. Changing the methods to cached properties will benefit BugTask:+create-question and presumably will benefit a job system that sends multiple messages for a single question.

Tags: qa-ok timeout

Related branches

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Brad Crittenden (bac)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.